Skip to content

CLDSRV-932: validate x-amz-content-sha256#6208

Open
leif-scality wants to merge 6 commits into
development/9.4from
bugfix/CLDSRV-932-check-x-amz-content-sha256
Open

CLDSRV-932: validate x-amz-content-sha256#6208
leif-scality wants to merge 6 commits into
development/9.4from
bugfix/CLDSRV-932-check-x-amz-content-sha256

Conversation

@leif-scality

@leif-scality leif-scality commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Reject a SigV4 request if the sha256 of the body does not match the x-amz-content-sha256 header

@bert-e

bert-e commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-932 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.0

Please check the Fix Version/s of CLDSRV-932, or the target
branch of this pull request.

@leif-scality leif-scality changed the title CLDSRV-932: validate x-amz content sha256 CLDSRV-932: validate x-amz-content-sha256 Jun 26, 2026
Comment thread lib/auth/streamingV4/ContentSHA256Transform.js Dismissed
Comment thread lib/auth/streamingV4/ContentSHA256Transform.js Dismissed
Comment thread package.json
"@opentelemetry/instrumentation-mongodb": "~0.69.0",
"@smithy/node-http-handler": "^3.0.0",
"arsenal": "git+https://github.com/scality/arsenal#8.5.0",
"arsenal": "git+https://github.com/scality/arsenal#improvement/ARSN-602-add-XAmzContentSHA256Mismatch-error",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arsenal is pinned to a branch (improvement/ARSN-602-add-XAmzContentSHA256Mismatch-error), not a tag. Git-based deps must pin to a release tag before merging.

Comment thread tests/unit/api/apiUtils/integrity/validateChecksums.js Outdated
Comment thread tests/unit/api/apiUtils/integrity/validateChecksums.js Outdated
Comment thread tests/unit/api/apiUtils/integrity/validateChecksums.js Outdated
Comment thread tests/functional/raw-node/test/xAmzContentSha256Mismatch.js Outdated
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9478 2 9476 0
View the full list of 2 ❄️ flaky test(s)
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With default signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 89 times)

Stack Traces | 0.014s run time
We encountered an internal error. Please try again.
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 82 times)

Stack Traces | 0.014s run time
We encountered an internal error. Please try again.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@leif-scality leif-scality force-pushed the bugfix/CLDSRV-932-check-x-amz-content-sha256 branch 2 times, most recently from 969e37f to ffbc547 Compare June 26, 2026 15:52
Comment thread lib/api/apiUtils/object/validatePayloadProtocol.js
@leif-scality leif-scality force-pushed the bugfix/CLDSRV-932-check-x-amz-content-sha256 branch from ffbc547 to e9c49e2 Compare June 26, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants