Skip to content

test(ui-react): await cap retirement before polling the limit panel #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 1 commit into from
Oct 16, 2026
Merged

test(ui-react): await cap retirement before polling the limit panel #2002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/ui-react/tests/browser/hygiene-actions-limit.layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,14 @@ async function fill(longFinding = false) {
const result = await set({ longFinding, fillActions: true });
expect(result.read.review.pendingActionId, "cap clears the authoritative pointer").toBeUndefined();
expect(result.read.action).toBeNull();
const reason = result.read.review.pauseReason!;
// Filling commits on the server before the browser drains the Action burst.
// Start the presentation deadline only after the real retirement reaches it.
await expect.poll(() => ui!.stores.inbox.getState().items[reason.retiredActionId]?.status,
{ message: "cap retirement reaches the browser" }).toBe("dropped");
await expect.poll(() => panel()?.dataset.hygieneLimit).toBe("L1");
await expect.poll(() => host!.querySelector("[data-hygiene-id]"), { message: "retirement clears the visible finding" }).toBeNull();
return result.read.review.pauseReason!;
return reason;
}
function noCard() {
expect(host!.querySelector("[data-hygiene-id]"), "retirement renders no hygiene card").toBeNull();
Expand Down
Loading