Repository navigation
docs(storage): finalize the approved inspection and removal design - #2015
Merged
Merged
Conversation
This was referenced Oct 16, 2026
Owner
Author
|
Automatic main-push CI 38844260772, attempt 1, passed on squash
The squash parent/tree match the PR combined checkout documented above. #1782 is closed and both issue/PR retain 0.44.0. The storage implementation remains in native #1779 children #2009–#2014; #2009 and #2014 are unblocked, while the dependent implementation issues remain blocked on their open prerequisites. No product implementation or release publication is claimed. |
This was referenced Oct 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1782
What changed
The approved Storage design is now a self-contained design-kit record, with desktop and 320px wireframes for overview, drill-down, filtering, file inspection, selected removal and mixed outcomes. It records the eighth Settings pane, allocated-size default, decimal units and the requirement to ship the first public pane with safe binary removal. The navigation record and design index link the decision.
The implementation chain is scoped as native #1779 children: #2009 core inventory → #2010 server inventory → #2011 maintenance / #2012 safe binary removal → #2013 complete pane. #2014 separately designs deferred growth and low-space guidance. None of those filings claims a shipped implementation.
Why this shape
This consolidates the maintainer's complete-design approval and S1=A/S2=A/S3=A/S4=B, without another approval round. It preserves the accounting/lifecycle/native-storage boundaries, distinguishes logical entry totals from physical-object union, keeps unknown measurements explicit, and does not equate untracked files with missing recovery coverage. The design's original read-only-first recommendation and optional binary display units are superseded by the controlling rulings.
Current source review corrected the issue's obsolete Settings citations. The separate attribution input correction #1787 is already merged through #2007.
Proof
04ef3552190d8f56eab09dd6c3580101b6385ba4.bun run check:pr --base origin/main: passed, including lint/leakage and 345 tests across 16 affected invariant files (1,248 assertions).a16cf167d31a5d3a9a385bdd637249795229b762. Changeset job 116788684015, verify job 116788842949 (345 tests) and proof job 116788934725 all checked out4c1ca69f316bbd82c0abc8aa7cefbce00a5ecd11, with parents5e9854b2e53ab7cfb4364008cf9cd2065b369404and the head, tree53073377144c0660ed69f8d795c7b953cd6b02e9. Contract run 38843501643/job 116788682722 passed on the head. Remaining proof categories were intentionally excluded by the docs-only planner. Main advanced by the unrelated renderer phase-clock test change test(render): control registered renderer phase deadlines #2006 after local source review; the recorded hosted combined checkout already includes it. PR and issue milestones read back as 0.44.0; registry latest is 0.43.1.Checklist
docs/reflect the change, or nothing documented moved.Anything left open
Nothing for the design spike. Product implementation remains in #2009–#2013; growth/low-space design in #2014. Remote/provider usage, host/container stores, per-file Git attribution, derivative grouping, workspace cleanup and new retention defaults are explicitly deferred. #1779 stays open until its product definition of done is met.