Repository navigation
fix(ui-server): remove routine budget note and restore legacy replay - #2106
Merged
Merged
Conversation
schlessera
force-pushed
the
fix/2051-budget-note-replay-p02051a
branch
from
October 16, 2026 12:38
657ab7a to
0d658e7
Compare
schlessera
changed the base branch from
main
to
fix/2049-preserve-provider-transcript-p0204916
October 16, 2026 12:38
schlessera
added this pull request to stack #2136
October 16, 2026 12:38
schlessera
marked this pull request as ready for review
October 16, 2026 12:40
schlessera
removed this pull request from stack #2136
October 16, 2026 12:46
schlessera
marked this pull request as draft
October 16, 2026 12:46
schlessera
changed the base branch from
fix/2049-preserve-provider-transcript-p0204916
to
main
October 16, 2026 12:46
schlessera
force-pushed
the
fix/2051-budget-note-replay-p02051a
branch
from
October 16, 2026 14:27
0d658e7 to
eb10f05
Compare
schlessera
marked this pull request as ready for review
October 16, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2051
What changed
Governed turns pass their assembled prompt unchanged to the backend. UI replay removes only the exact legacy 0.42/0.43 trailing budget suffix before local-command and message-source joins, restoring command order, voice source, thinking level and file metadata without rewriting saved provider transcripts. The measurement harness carries the actual host-owned prepared prompt receipt to its strict worker observer, preserving the reviewed original and exact provider bytes.
Why this shape
This ordinary PR now contains only #2051's 14-file layer on delivered main; its former context and saved-history prerequisites have merged. Static session limits, actionable changed-tail context, current governance/budget fields and replay provenance remain intact. Integration preserves the incoming
createTurnLifecycleimport and all lifecycle behavior; the only runtime prompt changes are removal of the routine note and UI-only legacy replay stripping. Measurement instrumentation stays in existing private preloads, with no production event, field or extension seam. Includes a server patch changeset and required historical citation updates.Proof
eb10f050d1b7339faa2751b03781d45cf43d7c59, based6b527290fe203fca7f653464895e92775ec422f, treed58b68c61126f7526a8c30c8cbf2c77ce929c576. The preserved own layer applied cleanly initially; the later import conflict was resolved by retaining incoming lifecycle wiring and removing onlyinferenceBudgetNote. No upstream history/provenance or new governance code was replaced.0d658e7ca5a1ef98860ad1b79653782931a1b63c, treef3261f4bcfb381eb1bced8a039aae97b01bda102, parent395ff3a0f3981f2da9cebb17aa6a4dc887a7a94a: focused 53 / 206, restored budget/replay 9 / 93, native exact/negative 2 / 35, typecheck, and parent-based local preflight 864 tests / 5541 assertions plus lint/leakage/changeset gates pass. These retain their original SHA and are not relabelled as a fresh combined-main receipt.GOVERNED_PROMPT_PRESERVES_USER_BYTEScases; bypassing the legacy strip fails both adapters'LEGACY_LOCAL_EXCHANGE_ORDER; reaching actual-user metadata first failsLEGACY_MESSAGE_METADATA; appending input after host receipt capture fails the actual native observer withActual Codex input differs from the exact expected user-plus-host prompt.All sources were restored byte for byte and controls passed.run-session.ts; focused host tests exercise the integrated turn path. Earlier standalone/prospective receipts remain attributed to their original trees. Per the user's explicit direction, there is no new full refresh solely for base advancement. Global/current-head CI remains pending; no provider cache-hit or savings claim.Checklist
Anything left open
Current global CI is pending. #2154 owns two inherited documentation-citation anchors (
const sdkOptionsand the standalone Mermaid viewer branch); this PR does not claim that citation suite is green. Merge follows the user's explicit direction to retain previously passed full proof with focused integration evidence, without admin/protection bypass. Actual integrated-main, issue closure and milestone reconciliation remain required after merge.