Repository navigation
test(ci): await complete workspace owner PID publication - #2113
Draft
schlessera wants to merge 3 commits into
Draft
schlessera wants to merge 3 commits into
schlessera wants to merge 3 commits into
Conversation
schlessera
marked this pull request as draft
October 16, 2026 11:50
schlessera
marked this pull request as ready for review
October 16, 2026 11:50
schlessera
marked this pull request as draft
October 16, 2026 12:41
schlessera
force-pushed
the
test/1513-lease-pid-publication-h5d7
branch
from
October 16, 2026 12:41
d8c4442 to
4028a60
Compare
schlessera
added this pull request to stack #2140
October 16, 2026 12:41
This was referenced Oct 16, 2026
schlessera
removed this pull request from stack #2140
October 16, 2026 12:50
schlessera
marked this pull request as ready for review
October 16, 2026 12:50
schlessera
marked this pull request as draft
October 16, 2026 13:16
schlessera
force-pushed
the
test/1513-lease-pid-publication-h5d7
branch
from
October 16, 2026 13:18
4028a60 to
62eb397
Compare
schlessera
marked this pull request as ready for review
October 16, 2026 13:19
schlessera
marked this pull request as draft
October 16, 2026 13:47
schlessera
force-pushed
the
test/1513-lease-pid-publication-h5d7
branch
from
October 16, 2026 13:50
62eb397 to
97da4f0
Compare
schlessera
marked this pull request as ready for review
October 16, 2026 13:56
This was referenced Oct 16, 2026
schlessera
marked this pull request as draft
October 17, 2026 22:38
This was referenced Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1513
What changed
The workspace-lease fixture publishes a newline-terminated PID and waits for the complete positive safe integer before treating entry as ready. Empty files and positive partial prefixes cannot authorize a liveness probe against PID 0 or an unrelated process. Every entry-marker consumer uses the readiness check, and the signal tests use its validated PID.
The associated work-issue guidance checks the actual pull merge ref before reconfirmation because GitHub can retain an older base across a draft/ready transition.
Why this shape
The fixture publication boundary was reproduced in #1513. The original historical SIGTERM failures did not record the probed PID; this scoped repair does not classify those particular events. Production helper behavior, cleanup assertions, offline guards and deadlines remain unchanged. This two-file repair is independently useful and is also included unchanged in Storage PR #2172.
Proof
Current candidate
02bbaf411e07873045f369a57c35deb581cee104, integrated base498270fbdc4ef2788fdd3babb259b647d77f6c77, tree92925a83db0c4daa07665b523898cca1be4718ca.LEASE_EMPTY_PID_PUBLICATION_MUST_WAITwith PID 0. Independently accepting empty markers and unterminated positive prefixes makes the corresponding assertion fail; both pass after restoration. These earlier behavioral receipts retain their original source identities.PACKAGE_EXPORT_UNAVAILABLE; restoration passes. The production helper is unchanged in this PR.bun run check:pr --base origin/mainis failed: 955 fast tests pass, one fails, 6,323 assertions. Installed Vitest discovery hits its 15-second watchdog before JSON publication. Its structured receipt reports 15,229ms,timedOut: true, SIGKILL, zero stdout bytes and no inventory. Affected-test feedback did not start. The separate verification blocker is ci: file-only Vitest discovery reaches watchdog before inventory publication #2380.The earlier hosted executions passed their selected categories but their aggregate failed as stale. Their older checkout/base remain historical evidence; no current complete hosted pass is claimed and this PR stays draft.
Checklist
Anything left open
#2380 blocks the required local preflight. Selected hosted proof and actual squash/main verification remain required. The historical #2334 Storage bundle failure remains separate; independent delivery here does not qualify Storage or close that investigation.