Repository navigation
test(ui-server): measure native probe durations monotonically - #2218
Merged
Merged
Conversation
schlessera
marked this pull request as draft
October 16, 2026 19:12
schlessera
marked this pull request as ready for review
October 16, 2026 19:13
schlessera
marked this pull request as draft
October 16, 2026 19:15
schlessera
marked this pull request as ready for review
October 16, 2026 19:17
schlessera
marked this pull request as draft
October 16, 2026 19:19
This was referenced Oct 16, 2026
schlessera
marked this pull request as ready for review
October 17, 2026 09:49
schlessera
marked this pull request as draft
October 17, 2026 09:50
schlessera
marked this pull request as ready for review
October 17, 2026 09:53
schlessera
marked this pull request as draft
October 17, 2026 10:03
schlessera
marked this pull request as ready for review
October 17, 2026 10:09
schlessera
marked this pull request as draft
October 17, 2026 10:11
schlessera
marked this pull request as ready for review
October 17, 2026 10:19
schlessera
marked this pull request as draft
October 17, 2026 10:56
schlessera
marked this pull request as ready for review
October 17, 2026 12:28
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2180
Use performance.now() for the boot-probe test file’s eight elapsed observations and bounded polls. Preserve all thirteen original scenarios, native process/pipe/signal/warning/argv/liveness assertions and literal 4950/6500/1500 ms guarantees. Add forward/backward Date.now jumps around real five-second native probes, with direct-child cleanup/join and complete descriptor restoration even after failed assertions. Production clocks and timers remain unchanged.
Verification
Current candidate
7963e3d55bfd006508c52be672eb6350087f1810, integrated base7cc86931e763f0eca636b89abd78b3b5371ec027. Only packages/ui-server/tests/boot-probe-deadline.test.ts differs from that base (63 additions / 8 deletions); its source SHA256 remains363c847ea619052181bb2667eaa24fde4ce93139dd2a4b04503acd3549acc38e.ef5ba543ebb24238b18c96c0ddd50bc7280b8393, tree9d6c84bfcef5f152a943da476087c8ad483363b8, parents the recorded base/head above; all thirteen artifact digests and checkout receipts verify. The two clock controls pass in unit 3 at 5003.80 / 5033.07 ms. Execution cost: 7168 summed job wall-seconds and 989 event seconds, not CPU time or additive elapsed.9c52e8c020aca6d8c4dcea0a2afd1640bc1bf60bcontains only test(ui-server): amortize audited HTTP mount fixtures #1870 HTTP fixture pooling and fix(ui-sdk): validate restricted helper relay IPC #2335 restricted-relay validation beyond the hosted base. Neither changes this test, its production version-probe/exec-wrapper inputs, dependencies, preload or timing bounds. The prospective combined tree is0515c4d6e20c7a35f82251611f5fce6ccf3f5239, locally recorded at4dc10941121b3ec53fa4c07345a67a8221c72870, distinct from the hosted checkout. Relevant combined-tree preflight (53 / 1371 plus native 15 / 109), strict types and actual offline native identity/managed-checkpoint proof pass. Native proof retains restricted relay adverse cases, complete container/loop/worker/broker cleanup and unchanged namespace quota. Combined-tree HTTP mounts, launcher, runtime placement and sandbox focus passes 147 tests / 1310 assertions (one snapshot) across four files, 146.84 seconds.The previous full confirmation 39024472829 remains failed: 12 passing jobs, failed unit 4 (diagram binding #2314), failed runtime_host (Git ownership #2312), and stale-base aggregate. All fifteen actual checkouts were
30931b792cfe8c002d9ea77feb236b92c5f6dc33, parentsdcc09e9c8601f6513eec907cfbf7d3ffbc01bf16and53474e42be9864fc00a6ec71621e781ae206720e, tree90af48ae7ae902a6970760dc9343b2edbc151e19; all thirteen artifact digests verify. Its unit 3 passed this complete boot-probe file. #2326 and #2317 have since delivered the substantive corrections and are integrated here; the old failed workflow is not relabelled green. The native retained-namespace negative control was intentional and passed its verifier.The maintainer’s session instruction permits retaining honestly attributed proof across unrelated main advances and refreshing affected proof when changes could sway results. This integration includes relevant discovery/native/build-harness changes, so current qualification is requested. No coordinated pause or reservation is asserted.
Checklist
Anything left open
Merged normally with matching head as
fac14b12e10f13e0c9553f1a5dbfd6f606a1c2e0, parent9c52e8c020aca6d8c4dcea0a2afd1640bc1bf60b. Main ancestry and exact tree equality with the qualified combined tree0515c4d6e20c7a35f82251611f5fce6ccf3f5239are verified. #2180 is closed and both release 0.44.0 milestones are read back. Automatic main push 39033938992 is separately pending. #1939 is a separate saved implementation to refresh after this prerequisite lands; this PR does not close it or complete epic #1849.