Repository navigation
fix(ci): preserve runtime JavaScript and isolate native export source - #2274
Merged
Merged
Conversation
This was referenced Oct 16, 2026
schlessera
marked this pull request as ready for review
October 17, 2026 08:25
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2126. Closes #2271. Closes #2275. Successor to merged #2178; neither issue is claimed complete.
What changed
The native diagram export fixture runs unchanged SVG/PNG/PDF operations from a fresh private copy of tracked source, with exact workspace resolution and fresh configuration roots. A private preload refuses core-command dispatch and checks a zero-attempt receipt for each export. Proof discovery also resolves existing explicit JavaScript runtime files before neighboring TypeScript declarations, preserving actual Bun TypeScript fallback when JavaScript is absent.
Why this shape
The archive excludes stale build output and untracked JavaScript shadows while retaining six actual workspace domains and locked external dependencies. Immutable preparation requires the complete owned domain to match HEAD. Each invocation validates bytes, modes, canonical paths, guards and installed workspace aliases. No production CLI seam, provider permission, selected case or artifact assertion changes.
Proof
Head 0ab89b7 (test fixture successor to 53abd2d), based on actual #2178 squash ef6945f.
Checklist
Anything left open
The whole browser category remains fresh. The truthful inventory has 307 cases, while retained Worker metadata remains the older 305-case audit. Exact native producer, generated artifact/reference document and source materializer have not been admitted as a closed retained capability. No unknown is waived and no retained hit is claimed.
Independent bounded source review found no blocking issue for this preparation slice. Archive completeness relies on trusted preparation; external dependencies are linked rather than independently rehashed by this materializer. Both remain qualification obligations. A three-format kernel file diagnostic passed after the draft checkpoint, but is not counterfactual/static proof; four unknown-child-exit warnings remain recorded. Coordinator review resumed under claim p02126-native-resume-20261017. The prior bounded review missed two existing wrapper test files; that regression is now corrected and verified below.
Remaining #2126 work: complete exact-operation imports/callbacks and active-initialization audit; include all tracked producer inputs in immutable identity; prove activation/resource mutations; qualify current complete Worker boundary; obtain actual same-PR fresh browser shards and whole-success aggregate; demonstrate equivalent follow-up retention with independent validation, bounded API use and no proof chains. Existing run receipts remain preserved. A ready-for-review request is not proof until its selected jobs complete.
Wrapper fixture correction after bounded review
#2275 preserves the separate actual hosted project-list failures and new copied-module setup regression. At 53abd2d the two existing wrapper files report 1 pass / 16 fail because the copied runner lacks its new preparation dependency. These module-load failures are not counted as causal guard mutation proof.
The two test files now copy the real preparation dependencies, use a tiny owned tracked Git fixture where the actual source preparer executes, and explicitly expect both existing diagram projects. No production source, selected project, assertion, source pin or native export fixture changed in this correction. All 17 cases / 58 assertions pass. Removing only diagrams-chromium from actual default selection causes four named forwarding assertions to fail; restored exact runner bytes pass all 17. Strict types pass. Required check:pr on this successor passes 949 fast tests / 6304 assertions and 193 graph-feedback tests / 1536 assertions across 21 files. The unchanged actual native producer retains its earlier exact-source 178-case receipt; no new hosted success is inferred.
Fresh readback: historical #2178 confirmation 38970927775 and actual main 38971608455 completed with failures. Existing #2262 covers unhealthy-versus-shutdown; #2275 covers wrapper fixture expectations; separately filed hosted timeout observations preserve their unknown causes. Neither failed workflow qualifies as a retention baseline. Draft feedback 38977075237 intentionally skipped expensive categories, and its successful aggregate is not selected final confirmation.