Repository navigation
[ESSSPECTROSCOPY] Make BFIROST detector_number contiguous - #869
Merged
Merged
Conversation
1 task
github-actions
Bot
changed the title
SimonHeybrock
requested changes
Nov 12, 2026
SimonHeybrock
left a comment
SimonHeybrock
left a comment
Member
There was a problem hiding this comment.
I tested this with esslivedata release + the pixel-order check from scipp/esslivedata#1450 (without its reordering). As is, the check still raises in the BIFROST Q-map tests; with the coord transpose suggested below, all pass, so the reordering in #1450 could be dropped after we pin a release with this.
Could you add a test asserting that the detector_number coord of the merged detector is contiguous? That would have caught the issue below.
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
Member
Author
Done. |
SimonHeybrock
approved these changes
Nov 13, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See scipp/esslivedata#1450 (comment)