Skip to content

Generalise flat bank viewer - #871

Open
jl-wynen wants to merge 3 commits into
mainfrom
general-flat-bank-viewer
Open

jl-wynen wants to merge 3 commits into
mainfrom
general-flat-bank-viewer

Conversation

@jl-wynen

Copy link
Copy Markdown
Member

This PR generalises the FlatVOxelViewer if DREAM and moves the implementation into ESSreduce.

I changed how the dimension selector works to allow users some control over which dimensions are shown on which axis. And I also added support for slicing dims so we can get slicer plots at the same time.

Here is an example for the simualted BIFROST data:
flat-viewer

This was mostly written by Claude. I tested the widget with data fro dream and bifrost.

@jl-wynen
jl-wynen requested a review from nvaytet November 12, 2026 14:58
@github-actions github-actions Bot added essdiffraction Issues for essdiffraction. essreduce Issues for essreduce. essspectroscopy Issues for essspectroscopy. labels Nov 12, 2026
@jl-wynen
jl-wynen force-pushed the general-flat-bank-viewer branch from 6f95980 to a4bd5d7 Compare November 12, 2026 15:21
@g5t

g5t commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Does channel * length have the same sense as pixel number? E.g., can I multiply arc * tube by 900 and add it to channel * length to get the pixel number?
If so, then this could be a great starting point for a mpltoolbox interface to visualize/update a mask too (I guess that is already planned and/or implemented).

@jl-wynen

Copy link
Copy Markdown
Member Author

Does channel * length have the same sense as pixel number? E.g., can I multiply arc * tube by 900 and add it to channel * length to get the pixel number? If so, then this could be a great starting point for a mpltoolbox interface to visualize/update a mask too (I guess that is already planned and/or implemented).

This tool allows you to reorder the plot dims any way you like. But yes, in the example above, the order corresponds to the detector number.

We have not planned to add masking tools to this. But that could be an option in the future.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

essdiffraction Issues for essdiffraction. essreduce Issues for essreduce. essspectroscopy Issues for essspectroscopy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants