26.0.1: cmake, disabled prebuilt, unable to build with vulkan option enabled

[tgurr]

It was working in 26.0.0 and is new in 26.0.1. No matter which CMake options I set -DVULKAN_USE_PRECOMPILED:BOOL=FALSE -DFSO_BUILD_WITH_VULKAN:BOOL=TRUE, when enabling vulkan support it always tries to download stuff:

[...]
-- Downloading prebuilt libraries from "https://github.com/scp-fs2open/scp-prebuilt/releases/download/bin-b57636e0/bin-linux.tar.gz" (try 5/5)
-- Download of prebuilt binaries failed: "Could not resolve proxy name"!
-- Configuring incomplete, errors occurred!
[...]
CMake Error at lib/prebuilt.cmake:67 (message):
  5 download attempts failed!
Call Stack (most recent call first):
  lib/vulkan.cmake:96 (get_prebuilt_path)
  lib/CMakeLists.txt:46 (include)

Removing the offending line sed -e '/get_prebuilt_path/d' -i lib/vulkan.cmake allows me to build, so it should probably be gated behind the VULKAN_USE_PRECOMPILED option and not prevent it from working as intended.

Complete build log: fs2_open-26.0.1_build.log

[wookieejedi]

we are working on rebuilding 26.0.1 to fix this issue, thanks!

[wookieejedi]

We have re released it and hopefully that fixes hit issue 🤞

[tgurr]

We have re released it and hopefully that fixes hit issue 🤞

It does at least for 26.0.1, thanks! However the issue is still valid for current git master and needs to be adressed there.

The new 26.0.1 also changed (back) quite a few other bits, like SDL3 -> SDL2. Not really a fan of making changes to releases, tags, and their already released tarballs, especially since you've release candidates. So from a distribution maintainers perspective it's always better to raise the version and do a patch release (maybe yanking the broken one - or add a note). That said not sure what went wrong here, judging from the extensive changes it seems like something slipped in which shouldn't have or release release workflow didn't work like expected. Anyways things happen.

[BMagnu]

Apparently 26.0.1 was just mistakenly built on the wrong commit.
All of the accompanying RCs were on the 26.0 branch with individual fixes applied, and never had SDL3 or Vulkan, those were all 26.2 features that slipped in this time because of this wrong tag.
So effectively this is just what happened.
26.0.1, in the first attempt, was just a broken commit we ended up removing and re-releasing to match the release candidates.
In fact, the binary should be identical to that of RC5.

[notimaginative]

It does at least for 26.0.1, thanks! However the issue is still valid for current git master and needs to be adressed there.

An oversight combined with insufficient testing on my part. Should hopefully be fixed with #7789.