Conversation
|
I'm kinda leaning toward that it would make more sense to move it to cover the early warpout case too, as a modder, though then is should be gated by a game settings flag that is auto enabled for 26.0 I think. Happy to hear others thoughts, too! |
|
I will have to look into it, as of right now I do not have the available time as am in my high school finals. |
|
I'm looking back into this, may be intermittent, but I'm trying to do what was requested by wookieejedi. |
73d21f3 to
74d04af
Compare
|
So the behavior is still unsatisfactory, I've uploaded the code mainly for review purposes. Most of my tests were inconclusive, I do infact have the setting in the game_settings.tbl enabled so that shouldn't be an issue. Lastly @Goober5000 mentioned in the issue post that there's similar code that handles the negation of player/AI to be jostled by shockwaves but in my search I've not been able to find it. I am also realizing now that the code should handle for the player case too, I will attempt that when I have time, and I also want to know if the handling for AI is well enough before tackling that. |
This attempts to fix: #6444, however the only other question would be, is if we also apply this fix to when ships are within just the early stages of the warpout sequence when they're still vulnerable. Because during my tests the ships, including the player's are still jostled by the shockwaves in the early stages, only when the camera takes over as seen in the player's video does the fix take into place, so this is really a very short window in which ships don't get jostled, which would defeat what the fix is trying to do.
FIXED.mp4
LATEST-NIGHTLY-UNFIXED.mp4
FIXED-WITH-PLAYER.mp4