refactor: decouple language layout assumptions from GeneralKeyboardIME (Part 5/6) (#426) - #673
Merged
andrewtavis merged 1 commit intoAug 14, 2026
Conversation
9 tasks
andrewtavis
approved these changes
Aug 14, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: Changes are great, @prince-0408! Thanks so much for your support here and the dedication to all of these refactors! 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is Part 5 of 6 in modularizing
GeneralKeyboardIMEfor #426.It removes hardcoded language name checks (
"English","Russian","Swedish","German") for layout configurations (like conjugate view grid size and plural capitalization) fromGeneralKeyboardIME.ktand decouples them into overridable configuration properties in language subclasses.Detailed Changes Table:
GeneralKeyboardIME.ktdefaultConjugateModeType: String = "3x2",defaultConjugateLayoutXML: Int = R.xml.conjugate_view_3x2,isPluralCapitalized: Boolean = false) and removed all hardcoded language name checks.EnglishKeyboardIME.ktdefaultConjugateModeType = "2x2"anddefaultConjugateLayoutXML = R.xml.conjugate_view_2x2.RussianKeyboardIME.ktdefaultConjugateModeType = "2x2"anddefaultConjugateLayoutXML = R.xml.conjugate_view_2x2.SwedishKeyboardIME.ktdefaultConjugateModeType = "2x2"anddefaultConjugateLayoutXML = R.xml.conjugate_view_2x2.GermanKeyboardIME.ktisPluralCapitalized = true.Key Benefits:
GeneralKeyboardIMEcontains zero hardcoded assumptions orwhen (language)checks for layout configurations.GeneralKeyboardIME.kt.Related Issue
Refactors part of #426