Fix warnings - #964
Conversation
The strings didn't use the characters they intended because the backslashes effectively resulted in special characters. We fix them by marking the strings as raw.
The operator `is not` comapres the memory addresses of two objects. Since we're comparing an expression against a literal, it made no sense and was reported by Python. Fix it by moving on to using the operator `!=`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes update two regex declarations to raw string literals and change the pending-callback loop from identity comparison to value comparison. Matching behavior and callback-loop behavior remain unchanged. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Pull request overview
Fixes Python warnings without changing runtime behavior.
Changes:
- Uses raw strings for regex patterns.
- Replaces an integer identity comparison with a value comparison.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/unit/test_exception.py |
Fixes regex escape warnings. |
tests/unit/io/utils.py |
Fixes improper integer identity comparison. |
tests/integration/__init__.py |
Fixes regex escape warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address warnings pointed out in CI.
Backport: not necessary. This PR simply fixes some warnings.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.