Skip to content

Fix warnings - #964

Merged
Lorak-mmk merged 2 commits into
scylladb:masterfrom
dawmd:fix-warnings
Aug 4, 2026
Merged

Fix warnings#964
Lorak-mmk merged 2 commits into
scylladb:masterfrom
dawmd:fix-warnings

Conversation

@dawmd

@dawmd dawmd commented Aug 3, 2026

Copy link
Copy Markdown

Address warnings pointed out in CI.

Backport: not necessary. This PR simply fixes some warnings.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • (N/A) I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • (N/A) I have provided docstrings for the public items that I want to introduce.
  • (N/A) I have adjusted the documentation in ./docs/source/.
  • (N/A) I added appropriate Fixes: annotations to PR description.

dawmd added 2 commits August 3, 2026 23:00
The strings didn't use the characters they intended because
the backslashes effectively resulted in special characters.
We fix them by marking the strings as raw.
The operator `is not` comapres the memory addresses of two
objects. Since we're comparing an expression against a literal,
it made no sense and was reported by Python. Fix it by moving
on to using the operator `!=`.
Copilot AI review requested due to automatic review settings August 3, 2026 21:06
@dawmd dawmd self-assigned this Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 4a4b7f29-5ff0-443a-ae11-c3ec985643a8

📥 Commits

Reviewing files that changed from the base of the PR and between bbd4f05 and 37d56e9.

📒 Files selected for processing (3)
  • tests/integration/__init__.py
  • tests/unit/io/utils.py
  • tests/unit/test_exception.py

📝 Walkthrough

Walkthrough

The changes update two regex declarations to raw string literals and change the pending-callback loop from identity comparison to value comparison. Matching behavior and callback-loop behavior remain unchanged.

Suggested labels: area/Driver_-_python-driver

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: fixing CI warnings.
Description check ✅ Passed The description summarizes the warning fixes, explains the backport decision, and includes the complete checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Python warnings without changing runtime behavior.

Changes:

  • Uses raw strings for regex patterns.
  • Replaces an integer identity comparison with a value comparison.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/unit/test_exception.py Fixes regex escape warnings.
tests/unit/io/utils.py Fixes improper integer identity comparison.
tests/integration/__init__.py Fixes regex escape warnings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dawmd

dawmd commented Aug 4, 2026

Copy link
Copy Markdown
Author

The CI failure is #965. I sent a fix: #966.

@Lorak-mmk
Lorak-mmk merged commit 1d7e601 into scylladb:master Aug 4, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants