Repository navigation
test(helpers): match candidates path with native separator - #463
Merged
Merged
Conversation
![Chloe41427[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Signed-off-by: Chloe41427[bot] <chloe@sdkman.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should_fail_if_candidate_file_is_missingfails on Windows (run 40044460349). It asserts that the error containsvar/candidates, but the message renders the path withPath::display(), which uses native separators, so on Windows it readsvar\candidates.The test now builds the expected path with
Path::join, so it matches the platform separator. Production code is unchanged; the error message was already correct on every platform.Note on CI
pull_request.ymlruns onpull_request_targetand checks out the base branch, not the PR head. The PR checks here therefore testmaster, so they are expected to fail on Windows until this is merged. The push build onmasterafter the merge is the real verification.