Repository navigation
test(version): assert the missing-file error per os - #466
Merged
Merged
Conversation
![Chloe41427[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Signed-off-by: Chloe41427[bot] <chloe@sdkman.io>
chloe41427
Bot
force-pushed
the
fix/windows-version-test-os-error
branch
from
October 24, 2026 00:48
93bde84 to
73e03ec
Compare
chloe41427
Bot
changed the title
marc0der
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should_error_if_version_file_not_presentfails on Windows (run 40046406216). It asserts the Unix OS error textno such file or directory, but Windows reportsthe system cannot find the path specified. The error message is otherwise correct on Windows, including the forward-slashvar/versionpath from #465.The test now asserts the OS-specific message:
the system cannot find the path specifiedon Windows,no such file or directoryelsewhere. Production code is unchanged.This was the only failing test on Windows after #465; every other test target passed.
Test plan
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test(Linux arm64)masterpush build after merge (pull_request_targetbuildsmaster).