CapMap: Remove the root cnode upper bound#576
Open
cazb2 wants to merge 1 commit into
Open
Conversation
cazb2
force-pushed
the
callumb/remove_cnodesize_limit
branch
from
July 23, 2026 03:37
24f0748 to
cc9096a
Compare
| } | ||
|
|
||
| /// Returns the number of bits required to repr the input | ||
| pub fn calculate_size_bits<T: Into<u64>>(size: T) -> u8 { |
cazb2
force-pushed
the
callumb/remove_cnodesize_limit
branch
from
July 23, 2026 03:38
cc9096a to
43876f8
Compare
Collaborator
|
I want to think about the mechanics of this. The original plan was to expand the sub-cnode, I'm not sure about the root right now. |
This commit determines the size of the root cnode based upon the largest slot number that is specified in the sdf. Signed-off-by: Callum <c.berry@student.unsw.edu.au>
cazb2
force-pushed
the
callumb/remove_cnodesize_limit
branch
from
July 23, 2026 03:47
43876f8 to
b1eda39
Compare
Contributor
Author
|
Does that imply a refactor such that any user specified caps won't live in the root cnode but a subcnode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit determines the size of the root cnode based upon the largest slot number that is specified in the sdf. It then uses the appropriately sized cnode object in the spec.