Repository navigation
chore(release): add a release workflow skill - #69
Conversation
There was a problem hiding this comment.
Docs-only change, and the workflow matches the repo — approving.
Checked
- The rules it cites are real:
scripts/check_commit_msg.pyenforces the Conventional Commits subject (type list, imperative, lowercase, no trailing period), and.github/workflows/validate.ymlchecks for the bold**Summary**/**Changes**/**Testing**sections. - The files and options it names exist:
PTN_BUILD_TESTSinCMakeLists.txt, the version inproject(... VERSION ...), andpackaging/vcpkg/portfile.cmake/vcpkg.json. The note about keeping upstream'sREPO sentomk/patterniacasing makes sense, since the in-repo portfile usesSentoMK/patternia. - Phase 1 mirrors what the v0.9.5 release PR did (release note, perf note, page registration in three places, version bumps), and keeping the portfile SHA512 out of the release PR is the right call since it needs the tag.
One non-blocking nit (inline): the vcpkg fork step describes the commit order twice in ways that read as contradictory. Details on the line.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Problem - Releasing needs a fixed sequence across the repo, GitHub and two vcpkg repositories, and the details live only in past PRs. Implementation - Add .claude/skills/release/SKILL.md covering the release PR, the performance measurement, tagging, the GitHub release, the portfile SHA512 and the sentomk/vcpkg and microsoft/vcpkg updates. - Record the commit and PR rules the workflow must follow, including no Co-Authored-By trailer. Tests - Docs only; steps follow the v0.9.4 release and the merged microsoft/vcpkg PRs for patternia.
eb3555a to
0da25e9
Compare
There was a problem hiding this comment.
Re-reviewed the force-push to 0da25e9. The only change from eb3555a is Phase 1 step 1: the release branch is now release/X.Y.Z (no v) instead of chore/release-vX.Y.Z. That's consistent with the rest of the skill (the tag and patternia-X.Y.Z fork branch carry their own prefixes) and doesn't affect any other step.
The earlier non-blocking nit about the x-add-version / commit order in Phase 2 step 4 still applies, but it isn't a blocker. LGTM.
Benchmark comparison (informational)Base Noise estimate: the 20 control rows below do not run Patternia code, so they should not change between base and PR. As a group they moved by a median of +0.0% (run order and machine drift); that offset is divided out of the Patternia deltas (Adjusted). The controls then scatter by a median of 0.4%. Adjusted differences under 5.0% are treated as noise. Patternia: 8 benchmarks, 0 slower, 0 faster, 8 within noise.
Control rows (not Patternia code)
Raw results and the comparison chart are attached to this workflow run as an artifact. Shared runners are noisy, so use this as a trend, not a measurement. |
Summary
Adds a project skill that describes the release workflow used for v0.9.4 and v0.9.5, so a release can be prepared and published from one instruction. The skill is documentation for the agent; it changes no library code.
Changes
.claude/skills/release/SKILL.md: release PR steps (changelog, performance note with a measurement method, version bumps, registration), post-merge steps (tag, GitHub release, portfile SHA512), and thesentomk/vcpkgandmicrosoft/vcpkgupdate.Summary/Changes/TestingPR bodies, noCo-Authored-Bytrailer.Testing
scripts/check_commit_msg.py.