Repository navigation
docs: move the release skill to ai/skills and add AGENTS.md - #73
Conversation
![biobo-bot[bot]](https://avatars.githubusercontent.com/in/5358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nice cleanup: moving the skill to a tool-neutral ai/skills/ and keeping a symlink for Claude Code is a sensible layout. The move is a pure rename (100% similarity), and I spot-checked AGENTS.md against main: the build commands (PTN_BUILD_TESTS, the ptn_tests target, ctest), the header-only C++17 layout under include/ptn/, the clang-format pin in tools/requirements.txt, the Conventional Commits check in scripts/check_commit_msg.py, the one-commit rule, the 72-column body wrap, and the **Summary** / **Changes** / **Testing** sections all match CONTRIBUTING.md and the workflows. No library code changes, so nothing here can affect the build.
Approving. I left two small non-blocking notes: one about two rules that live in the release skill but not in CONTRIBUTING.md, and one about how the symlink behaves on Windows checkouts.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Benchmark comparison (informational)Base Noise estimate: the 20 control rows below do not run Patternia code, so they should not change between base and PR. As a group they moved by a median of +0.4% (run order and machine drift); that offset is divided out of the Patternia deltas (Adjusted). The controls then scatter by a median of 0.9%. Adjusted differences under 5.0% are treated as noise. Patternia: 8 benchmarks, 0 slower, 0 faster, 8 within noise.
Control rows (not Patternia code)
Raw results and the comparison chart are attached to this workflow run as an artifact. Shared runners are noisy, so use this as a trend, not a measurement. |
341227f to
3cd4145
Compare
Problem - The release skill lives under .claude/skills, which only Claude Code reads, and nothing tells other agents that it exists. Implementation - Move the skill to ai/skills/release/SKILL.md. - Keep a .claude/skills/release/SKILL.md stub with the same front matter that points Claude Code at the moved file; a plain file rather than a symlink, so it also works on Windows clones. - Add AGENTS.md with the build and test commands, the pull request rules, and an index of the skills with how to add one. - Add the release/X.Y.Z branch prefix and the no-attribution rule to CONTRIBUTING.md so AGENTS.md only restates its rules. Tests - Docs only; the stub's link resolves to the moved SKILL.md.
3cd4145 to
b7570e6
Compare
There was a problem hiding this comment.
Re-checked at b7570e6: both earlier notes are addressed. CONTRIBUTING.md now has the release/X.Y.Z prefix and the no-attribution rule, and .claude/skills/release/SKILL.md is a plain stub (same front matter, links to ai/skills/release/SKILL.md), so Windows clones without symlinks still get the skill. Docs only; no C/C++ files touched, so clang-format isn't involved, and the commit subject passes scripts/check_commit_msg.py. Links in AGENTS.md and the stub resolve. LGTM.
There was a problem hiding this comment.
Re-reviewed b7570e6. Both earlier notes are addressed: CONTRIBUTING.md now has the release/X.Y.Z prefix and the no-attribution rule, and the .claude/skills/release/SKILL.md stub is a plain file whose relative link (../../../ai/skills/release/SKILL.md) resolves to the moved skill, so it works on Windows clones too. The moved ai/skills/release/SKILL.md is byte-identical to the old file, and AGENTS.md is consistent with CONTRIBUTING.md. LGTM.
Summary
Make the release skill available to every agent, not only Claude Code. The skill moves to
ai/skills/, and a newAGENTS.mdtells agents where skills live and what the repository's change rules are.Changes
ai/skills/release/SKILL.md: moved from.claude/skills/release/SKILL.md, content unchanged..claude/skills/release/SKILL.md: a plain-file stub with the samename/descriptionfront matter that tells the agent to read and followai/skills/release/SKILL.md, so Claude Code still discovers the skill. A regular file rather than a symlink, so it also works on Windows clones withcore.symlinks=false.AGENTS.md: build and test commands, branch and pull request rules (pointing atCONTRIBUTING.mdfor the full text), a skills index, and how to add a skill with a stub.CONTRIBUTING.md: add therelease/X.Y.Zbranch prefix and the rule against attribution trailers (Co-authored-by:, "Generated with" lines), soAGENTS.mdonly restates rules that live there.Testing
../../../ai/skills/release/SKILL.mdresolves to the moved file.scripts/check_commit_msg.py.