Fix NullPointerException in EmpowerPlantActivity cart count update - #268
Open
cursor[bot] wants to merge 1 commit into
Open
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add null check before updating textCartItemCount in onResume() to prevent NPE when the subscription fires before onCreateOptionsMenu() inflates the menu. The Android lifecycle calls onResume() before the options menu is created, so textCartItemCount may be null on first emission. Fixes [ANDROID-MN](https://demo.sentry.io/issues/7694740115/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 885 +2
Branches 67 67
=====================================
- Misses 883 885 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a NullPointerException that occurred when updating the cart badge count in EmpowerPlantActivity. The root cause was that
onResume()sets up an RxJava subscription that can emit immediately, but thetextCartItemCountTextView is only initialized later inonCreateOptionsMenu()which Android calls afteronResume(). The fix adds a null check before callingsetText()to safely handle the case where the menu hasn't been inflated yet.This pull request was triggered by a Seer handoff from Sentry.
Fixes ANDROID-MN