Fix NullPointerException in EmpowerPlantActivity cart badge - #269
Open
cursor[bot] wants to merge 1 commit into
Open
Fix NullPointerException in EmpowerPlantActivity cart badge#269cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add null check before updating textCartItemCount to prevent NPE when onResume() fires before onCreateOptionsMenu() inflates the options menu. The RxJava subscription can emit before the menu is created, causing a crash when trying to update the null textCartItemCount view. Fixes [ANDROID-MN](https://demo.sentry.io/issues/7694740115/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 885 +2
Branches 67 67
=====================================
- Misses 883 885 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a NullPointerException that occurs when launching EmpowerPlantActivity. The issue was caused by an Android lifecycle ordering problem:
onResume()sets up an RxJava subscription to update the cart badge count, but the subscription can emit beforeonCreateOptionsMenu()has inflated the options menu and initialized thetextCartItemCountview. The fix adds a null check before updating the badge, preventing the crash when the view hasn't been created yet.This pull request was triggered by a Seer handoff from Sentry.
Fixes ANDROID-MN