Repository navigation
Enhance SerpApiError information #15
Description
Activity
Really good point. With the large number of endpoints implemented by SerpApi.com, SerpApiError class should be enhanced to store search parameters and response metadata which includes search ID.
I guess all the library should be improve with the same behavior.For the empty result, the backend service do the work of figure out any error, and provide an error field easy to consume.
We don't want to wire any complex logic in the library to figure the pontention problem with the 100+ API endpoints.can you work on the implementation fix on a branch ?
for example: code changes in the library
message = "HTTP request failed with error: #{data[:error]} from url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status} " raise SerpApiError(message, result)
them the user can obtain the raw results from the exception.
begin results = client.search(q: 'coffee') rescue SerpApiError => e search_id = e.results[:search_metadata][:id] puts "search failed with search_id=#{search_id} with results=" pp e.results end
Metadata
Metadata
Assignees
Labels
No labels
Provide a
search_idfor failed searches when available.The
SerpApiErrortype does not provide any information. Ideally, there would be an attribute for storing the search ID that would then be assigned before raising the error. Additionally, information is included in the error message that is not included in the error message itself:In practice, I have a case where a search returns an empty set - fine - but the client treats this as an error condition. Without saving the search ID in the error, I cannot automatically collect failed search IDs. Instead I'm forced to cross reference the search parameters with my list of historical searches.
I'd also suggest that we not consider empty searches to be an error simply by virtue of an empty result. Regardless, code using the client cannot differentiate between an error involving network connectivity and an empty result set.