Repository navigation
parser: Don't ignore a closing curly bracket from within the declaration parser. - #458
Merged
Merged
Conversation
…ion parser. Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=2065482. This gets the behavior that matches other browsers and is a one-liner. If you're in a block, `}` is the delimiter anyway (so the iterator can't see it). Otherwise, if you're not parsing qualified rules, you go to the skip-until-semicolon path. The spec is a bit broken here, see w3c/csswg-drafts#14565. Tests and review in https://phabricator.services.mozilla.com/D331713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=2065482.
This gets the behavior that matches other browsers and is a one-liner.
If you're in a block,
}is the delimiter anyway (so the iterator can't see it). Otherwise, if you're not parsing qualified rules, you go to the skip-until-semicolon path.The spec is a bit broken here, see
w3c/csswg-drafts#14565.
Tests and review in https://phabricator.services.mozilla.com/D331713