Skip to content

feat: drop bincode entirely - #426

Open
alejandro-vaz wants to merge 8 commits into
servo:v2from
alejandro-vaz:v2
Open

feat: drop bincode entirely#426
alejandro-vaz wants to merge 8 commits into
servo:v2from
alejandro-vaz:v2

Conversation

@alejandro-vaz

@alejandro-vaz alejandro-vaz commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

bincode drop

replaced test with serde_json instead

for the future: #428

@alejandro-vaz

Copy link
Copy Markdown
Contributor Author

ready for review

@alejandro-vaz alejandro-vaz changed the title feat: drop bincode entirely #398 feat: drop bincode entirely Aug 21, 2026
Comment thread README.md Outdated
Comment thread Cargo.lock
# It is not intended for manual editing.
version = 4

[[package]]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually removes one dep and adds a lot more? Seems unfortunate?

@alejandro-vaz alejandro-vaz Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#428 already plans to remove it, but the priority was to remove bincode because it's unmaintained (#398)

@alejandro-vaz

Copy link
Copy Markdown
Contributor Author

oh no, this comes from failed CI at #396

clap requires edition 2024

@alejandro-vaz

Copy link
Copy Markdown
Contributor Author

this won't succeed until #396 is reverted with #430

Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
@alejandro-vaz
alejandro-vaz requested a review from emilio August 22, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants