Skip to content

recovery: #396 from @fereidani - #443

Draft
alejandro-vaz wants to merge 3 commits into
servo:v2from
alejandro-vaz:recover
Draft

recovery: #396 from @fereidani#443
alejandro-vaz wants to merge 3 commits into
servo:v2from
alejandro-vaz:recover

Conversation

@alejandro-vaz

@alejandro-vaz alejandro-vaz commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

this PR brings back #396 (ft. @fereidani) after downgrading criterion to v0.7 as specified in #430

@alejandro-vaz

alejandro-vaz commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

due to a labeling error on criterion, the real MSRV for criterion 0.5+ is 1.85 by depending on clap which requires clap_lex that uses edition 2024 (stabilized in 1.85)

so we are forced to downgrade to criterion 0.4

the MSRVs for criterion are mislabeled

@alejandro-vaz
alejandro-vaz marked this pull request as ready for review August 24, 2026 22:22
@fereidani

Copy link
Copy Markdown
Contributor

I reviewed the code once again, It worth mentioning that retain_mut panic and drop handling behavior of smallvec and rust library are different.
It would be nice if for version 2, smallvec start behaving like rust in case of panic.

@alejandro-vaz

Copy link
Copy Markdown
Contributor Author

@fereidani could you review this PR?? it would really help getting it merged upstream by the people from servo

@fereidani

Copy link
Copy Markdown
Contributor

Sure but my PR was 283 additions and 115 deletions. This PR is making some other changes that are not mine.
I'm currently reviewing and reporting some security vulnerabilities in some rust popular crates, I have priority over those for now as they are critical.
I can get back in about 3 days and send you a new PR forked from the new smallvec, Or maybe you can make this PR only limited to recovery of #396 without touching anything else so I can review that in few minutes instead.
Please let me know which you prefer.

@alejandro-vaz
alejandro-vaz marked this pull request as draft August 25, 2026 06:45
@alejandro-vaz

alejandro-vaz commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

yeah it looks I failed to do a proper rebase and the PR is removing changes that have been merged since

yeah please send the PR back when you can, three days is okay

I think you could get around by taking your old branch and doing a merge-rebase and that should be much faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants