Bound document-reviewer reruns to the received findings - #186
Merged
Merged
Conversation
A document-reviewer rerun with prior_feedback could reopen the whole document: "dependent consistency" and "confirming required safeguards still exist" left the rerun scope open, and the output contract kept returning `issues` on reruns. Pre-existing gaps missed by the initial review surfaced as new findings and restarted the correction cycle. Replace the open-ended scope with the received items and the boundaries their corrections changed, keep regression detection through the `resolved` condition, return reconciliation in place of issues, and derive the rerun verdict from those entries, matching code-reviewer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A document-reviewer correction re-review (a rerun with
prior_feedback) could turn into a second full review. Gaps that the initial review missed came back as new findings, and each one started another correction cycle. That breaks the convergence model, where the initial review reports everything and a rerun only confirms that the corrections are right.This PR closes the rerun scope in
agents/document-reviewer.mdby rewording existing rules. It adds no new mechanism.Cause
prior_feedback_reconciliation, so reruns still returnedissues, and the verdict still came fromissues.Changes (
agents/document-reviewer.md, three sentences replaced)resolvedonly when the changed boundary is still valid.prior_feedback_reconciliationin place ofissues.Also included: the patch version is bumped to 0.27.3, and the plugin copies are synced.
Considered and not changed
review-resolution.md): Adding "initial" looked needed, so that a rerun result withoutissueswould not be read as complete. In testing, the existing sections 2 and 3 already routed rerun results correctly (6/6), so the change was dropped.issueschannel on reruns, that focus can no longer produce new correction work, so the recipes are unchanged.Verification
I tested with
claude -p, using--plugin-dirand--agent dev-workflows:document-reviewer, on a synthetic repository. Its work plan had one applied finding (a verification command that could not run, now corrected) and a separate, pre-existing verification gap in a later phase that the correction did not touch. I compared themainand branch versions, 3 runs each:mainpass, findingresolved, no new findingsmaintained; no new findingsIn two
mainruns, the new finding also reused an ID that was already inprior_feedback.Orchestrator routing under
review-resolution.md, 3 runs each formainand the rejected variant:resolvedentrymaintainedapply entryclaude plugin validatepasses for the marketplace and all plugins.🤖 Generated with Claude Code