Stop security-reviewer from blocking on governing document type labels - #188
Merged
Merged
Conversation
The security-reviewer input gate rejected governingDocuments whose type label was not exactly "design-doc" or "work-plan", even when every path was readable. The reviewer never branches on the type value, so the check only stopped reviews over a label. Build and implement recipes do not spell out the accepted values, and document-reviewer uses a different vocabulary for the same documents (DesignDoc, UISpec), so callers can easily pass a label the gate rejects. Remove the type check from the Step 1 gate and the quality checklist. The gate now blocks only when governingDocuments is empty or a path is unreadable. Bump the patch version to 0.27.5. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
security-reviewerreturnedblockedwhen agoverningDocumentsentry used a type label other thandesign-docorwork-plan, even though every path was readable. The reviewer never uses the type value for anything, so this check only stopped reviews over a label.The label is easy to get wrong. The build and implement recipes ask for a "typed
governingDocumentslist" but do not name the accepted values.document-revieweralso names the same documents differently (DesignDoc,UISpec). So a caller that has been callingdocument-reviewerall session can easily passDesignDochere.This PR fixes it by removing the check, not by adding examples or aligning names across agents.
Changes
security-reviewer.md. The gate now blocks only whengoverningDocumentsis empty or a path is unreadable.Also included: the patch version is bumped to 0.27.5, and the plugin copies are synced.
Verification
I ran
security-reviewerwithclaude -pand--plugin-diron a small fixture repository, once with themaindefinition and once with this branch.mainDesignDoc+UISpeclabels, readable pathsblocked(invalid type)passafter checking the Design Doc's requirements against the codedesign-doclabel, missing pathblocked(file does not exist)claude plugin validatepasses for the marketplace and all plugins.🤖 Generated with Claude Code