ci: cancel upstream run on downstream cancellation#162
Merged
Jonas Elfering (keulinho) merged 2 commits intoJun 16, 2026
Conversation
5 tasks
Jonas Elfering (keulinho)
requested review from
Florian Ruppel (fruppel) and
Marcel Kräml (mkraeml)
| - name: Checkout code | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| - name: Test downstream wait | ||
| run: bash downstream/wait.test.bash |
Contributor
Author
There was a problem hiding this comment.
not sure if we want those test scripts 🤔
Contributor
There was a problem hiding this comment.
If the alternative would be to inline the code here then I would go with a test script for now.
We don't have a clear structure for testing workflows yet but this can be easily adapted later.
Florian Ruppel (fruppel)
approved these changes
Jun 16, 2026
Jonas Elfering (keulinho)
deleted the
codex/cancel-upstream-on-downstream-cancel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
upstream-tokeninput to the downstream action.cancelled, the action now cancels the upstream workflow run instead of reporting a generic downstream failure.Why
Downstream workflows can be cancelled by concurrency when a newer upstream push supersedes them. Surfacing that as a cancelled upstream run makes the check state match the real cause while still preventing the required downstream check from passing.
Validation
bash -n downstream/wait.bashbash downstream/wait.test.bashgit diff --checkRelates shopware/shopware#17450