Repository navigation
docs: catch the changelog up through CLI 1.6.130 and the 2026-10-20 deploy - #752
Conversation
…ys through 2026-10-20
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 1 (two fresh reviewers, CLI and server-side halves): 28 findings. All will be fixed.
CLI entries
delete-confirm-yes.md(high): says delete commands used to exit 0 on decline, but at v1.6.128channels deleteandapps deletehad no prompt (they required--confirm-name) andreleases deletedidn't exist. #4085 changedpatches set-trackand the native/asset "Continue anyway?" prompt ofshorebird patchfrom 0 to 1; the latter is missing.metrics-commands.md: theshorebird_plan_insufficient_tierbullet describes an error users can't hit today (every tier carries the Insights features inplan_feature.dart). Delete it.delete-confirm-yes.md: "apps deletestill needs the name, typed at the prompt" implies it already prompted; #4098 added that prompt in 1.6.129.cli-fixes-1-6-130.md: theUser-Agentvalue is truncated; #4106 sendsshorebird-cli/<version> (<os>; dart <version>).cli-fixes-1-6-129.md: "share one login refresh" overstates #4073. A second process reuses an unexpired token on disk or refreshes with the newest refresh token.cli-fixes-1-6-129.md: #4058 covers iOS framework patches too.cli-fixes-1-6-129.md: "before downloading anything" is too broad; #4051 checks before the release's artifacts are downloaded.cli-fixes-1-6-129.md: #4057 is about paths deleted before the command finishes, not already deleted.cli-fixes-1-6-130.md: missing "when it needs a confirmation", so it reads as if every command asks for--yes.release-patch-confirm-removed.md: the docLink target never mentions--confirm. Drop it.whoami-plan-only.md,release-patch-confirm-removed.md(nit): titles start lowercase, unlike every other entry.whoami-plan-only.md(nit):nullmeans the server didn't report a level.delete-confirm-yes.md,releases-delete.md(nit):--yesis also required in CI and with--json.patch-dex-diff-details.md(nit): the 10-method cap is per DEX file (#4072).
Console, API and Code Push entries
saml-sha1-refused.md: users see "SSO login failed" (saml_failedinauth-errors.ts), not "SAML sign-in failed".audit-log-siem-export.md:nextCursorwas a response field, not a parameter.api-errors-and-paging.md: #3517 addsWWW-Authenticateto 401s and scope 403s only, not every 403.patch-cache-cleared-on-delete.md: rollbacks already reached devices on the next check (#3571 only made a failed cache clear retryable), the release-delete fix was a race, and #3570 deletes the patches' files for that platform, not the patches.account/orgs.mdxMember roles table: Free has no Developer check, butplanOffersRolealways allows Developer (role_grants.dart:34), which two new entries state.audit-log-roles.md: Auditor is held only by service accounts (not on any plan's member roles), the bullet repeatsservice-accounts.md, and the summary should say Enterprise and the API.api-plan-limits.md: "Hobby" should be "Free", the role check reads the organization's plan, the blank-name rule is validation not a plan rule, and it applies on create too.account/orgs.mdxCreating an organization: only the name can be edited, and creating needs a paid plan of your own (can-create-organization.ts), otherwise the switcher shows "Upgrade to create an organization".delete-tracks-hide-rolled-back.md: the app transfer bullet (#3798) doesn't belong; move it toconsole-fixes-2026-10-18.md.patch-check-publish-race.md: the title doesn't cover the transfer bullet.enterprise/saml.mdxTroubleshooting: the docLink target doesn't list SHA-1 as a cause.enterprise/saml.mdxHow sign-in works: doesn't describe an existing account moving onto SSO.code-push/tracks.mdxDelete a track: only describes the CLI, not the new Console button.usage-owned-orgs.md(nit): the docLink should be Organizations & billing, not Overage billing. Also delete the two now-unused screenshots.
Verified correct: every date against the first prod deploy or release containing the change, every flag, code, limit and string not listed above, and no duplicates.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 2 (two fresh reviewers): 12 findings. All round-1 fixes landed. Fixing these now.
CLI
patch-dex-diff-details.mddocLink target: the troubleshooting section and thepatchoptions table never mention the new DEX detail or the public--show-dex-diffflag (patch_command.dartat v1.6.130). Add a paragraph and an options row.patch-dex-diff-details.md: the patch isn't blocked (in a terminal it asksContinue anyway?,--allow-native-diffspublishes), and the names come from each method's differing instructions only.cli-fixes-1-6-129.md: missing #4067.SHOREBIRD_PATCH_DD_MAX_BYTESstopped working in 1.6.129 (replaced by--dd-max-bytes), andcli-fixes-1-6-128.mdtells readers it's honored.cli-fixes-1-6-129.md: the refresh bullet leaves out that a network or server error now keeps the login and exits 75 instead of 70 (auth.dart).cli-fixes-1-6-129.md(nit): "On every platform" should be every platform that has a minimum; Android and AAR patchers have none.cli-fixes-1-6-129.md(nit): a non-numeric--org-idnow lists your organizations and their ids (organization_id.dart).release-patch-confirm-removed.md(nit):shorebird patchstill asksContinue anyway?for native and asset changes; what's gone is theWould you like to continue?prompt--confirmturned on.delete-confirm-yes.md(nit): each delete now says what it removes before deleting (#4098).
Console, API and docs pages
enterprise/saml.mdxTroubleshooting: two "or"s in the list, and nothing supports SHA-1 being one of the "most common causes". State it separately.delete-tracks-hide-rolled-back.md: only the Console lacks a delete button fordeactivated. The server refuses onlystable,betaandstaging(default_channel_names.dart), so the CLI and API can delete it.api-plan-limits.md(nit): the title still says "plan limits", but the blank-name bullet is validation.patch-cache-cleared-on-delete.md(nit): the docLink goes to rollback, but the entry is about deletes. Link Delete a track.
Note: one reviewer said invitations-commands.md is dated 2026-10-16. It's 2026-10-17 on main, so no change.
Verified correct: every date against the first prod deploy or release containing it, every remaining string, code, limit, label and plan gate, the removed screenshots have no references, no duplicates.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 3 (two fresh reviewers): 11 findings. All round-2 fixes landed. Fixing these now.
CLI and the pages it touches
code-push/release.mdx(5 samples) andcode-push/patch.mdx(1): sample output still showsWould you like to continue? (y/N) Yes, the promptrelease-patch-confirm-removed.mdsays is gone (removed in 1.6.130, #4107). The summary above it still prints and ends with a blank line, so only that line goes.releases-delete.md(nit):--platformalso removes the patch files built for that platform (releases_delete_command.dart, release.mdx).cli-fixes-1-6-129.md(nit): a non-numeric--org-idstill fails; the error's hint now lists your organizations.patch-dex-diff-details.md(nit): each instruction is also cut (defaultTokenLimit), so switch tables and array data are truncated.metrics-commands.md(nit):--granularityand--group-bybreak results down rather than narrow them, and the options vary by metric.
Console, API and docs pages
saml-sha1-refused.md,enterprise/saml.mdx: #3502 also refuses an RSA-SHA256 signature over a SHA-1 digest, so the fix must also say to digest with SHA-256.patch-cache-cleared-on-delete.md: round 1's wording was wrong. Per #3570 the platform delete already removed the patch files; it left the patch artifact rows, so devices were still offered patches that failed to download. The fix removes the rows.api-plan-limits.md(nit): the summary still says "plan limits".org-switcher.md(nit): #3558 only removed the header toggle; Appearance already existed.account/orgs.mdxMember roles intro (nit): roles depend on the organization's plan (its owner's), not "the plan that you have", matching the entries that link here.
Verified correct: every date and version, all remaining strings, codes, limits, labels and plan gates, docLinks, no duplicates, no stale "bottom left" or "My Organization" text.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 4 (two fresh reviewers): CLI half no findings; Console/API half 2 findings. All round-3 fixes landed. Fixing these now.
code-push/rollback.mdx(the rollback screenshot intro and the Roll Forward steps): since #3813 (prod 2026-10-18) the release page hides rolled-back and deactivated patches unless Show rolled back and deactivated is on (isWithdrawninutils/patches.ts). The steps send readers to a row they can't see. Say to turn the switch on.patch-check-publish-race.md(nit): per #3767 the racing check still returns its pre-publish answer; it's just no longer cached, so the next check sees the patch.
Verified correct: every date and version, every string, code, limit and label, the sample outputs against v1.6.130, plan gating, docLinks, no duplicates, no agent-facing text describing Console roll forward.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 5 (two fresh reviewers): 2 findings, both nits. All round-4 fixes landed. Fixing these now.
cli-fixes-1-6-129.md: missing #4071. RELEASE_NOTES 1.6.129 lists "shorebird account orgs --helplists every role", which now includesnonefor an organization where you only collaborate on apps.audit-log-actor-details.md: the trust-rule sign-in event (#3579) is already ingithub-actions-oidc.mdon main, same date. Keep only app creation and patch note edits.
Verified correct: every date and version, every string, code, limit, label and plan gate, sample outputs against v1.6.130, all docs page edits, no other docs page or agent file contradicted by an entry, no other duplicates, Prettier and style.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 6 (two fresh reviewers): 4 findings. All round-5 fixes landed. Fixing these now.
api-command.md(nit):--jqfilters only a successful response (if (succeeded && jq != null)), asaccount/api.mdxandagent-instructions.txtsay. The summary overstates it.patch-cache-cleared-on-delete.md(nit): the title and summary don't cover the rollback and roll forward bullet (#3571).console-fixes-2026-10-18.md: #3811 also changed the API.DELETE /api/v1/users/menow answers 202 withremaining_app_countwhile apps remain and must be repeated until 204 (DeleteUserInProgressResponsein openapi.yaml). Raw API callers see this.code-push/faq.mdx"Can you use Shorebird with your team?": "Hobby only supports a single developer" now reads against the Member roles table (Developer on every plan). What actually limits Free is that personal organizations can't take invitations (invitations/index.dart) and creating a team organization needs a paid plan (can-create-organization.ts, thecollaborationguard). Paid plans have no team size cap (maxTeamSizeis null withcollaboration).
Verified correct: every date and version, every string, code, limit, label and plan gate, all docs page edits, no other docs page or agent file contradicted, no duplicates, Prettier and style. Two 1.6.129 release-note items without entries (#4079, #4099) are internal.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 7 (two fresh reviewers): Console, API and Code Push half, plus all docs page edits: no findings. CLI half: 1 nit. All round-6 fixes landed.
api-method-and-paginate.md(nit): the summary covers only the method and--paginate, not the three bullets this PR adds (--jqslices #4104, repeated/api/v1#4109, the 405 hint). Fixing now.
Verified correct: every date and version, every string, code, limit, label and API shape (including the 202 remaining_app_count account delete), plan gating (planOffersRole, canCreateOrganization, maxTeamSize, Auditor), all docs page edits including the FAQ team answer, sample outputs against v1.6.130, no other docs page or agent file contradicted, no duplicates, Prettier and style.
AbhishekDoshi26
left a comment
There was a problem hiding this comment.
Round 8: no findings.
CLI half at 7cfba5a, plus the CLI docs pages. Round 7's nit landed: the api-method-and-paginate.md summary now covers --jq slices, the repeated /api/v1 handling and the 405 hint, all first shipped in 1.6.130 (api_command.dart at v1.6.130, absent at v1.6.129). git diff deab947 7cfba5a touches only that summary, so round 7's clean Console, API and Code Push half still holds. Spot checks against v1.6.128 to v1.6.130 (whoami, metrics subcommands, .dart_tool, --confirm, User-Agent), the six sample outputs, --show-dex-diff in patch.mdx and troubleshooting.mdx, Prettier and style all pass.
Dependencies
_shorebirdafter the 2026-10-20 prod deploy) are left out on purpose. docs: list Shorebird's hosts and how to download from an internal mirror #744 adds the mirror entry for the next CLI release.Description
Audits the changelog against every CLI release through 1.6.130 (
RELEASE_NOTES.md, PR bodies and source at each tag) and every successful "Deploy All to Prod" run in_shorebirdfrom 2026-10-08 through 2026-10-20, and adds the 29 user-visible changes that had no entry. Dates follow the template: the CLI release date, or the US Pacific day of the first prod deploy containing the change.CLI 1.6.129 (2026-10-16):
shorebird api,shorebird metrics,shorebird releases delete,--yeson deletes, one JSON object from every--jsoncommand, thewhoamiplan line, Apple builds keeping.dart_tool, and the remaining fixes.CLI 1.6.130 (2026-10-17): DEX diff details and
--show-dex-diff,--confirmremoved from release and patch, the remaining fixes (including the CLI'sUser-Agent), and three more bullets on the existingapi-method-and-paginate.md(--jqslices, repeated/api/v1, the 405 hint).Console, API and Code Push:
usage-owned-orgsorg-switcher,saml-sha1-refused,failed-payment-invoices-voidedaudit-log-siem-export,audit-log-roles,api-errors-and-paging,api-plan-limits,patch-cache-cleared-on-delete,wrong-provider-messageaudit-log-actor-detailsroles-plan-no-longer-offers,saml-first-sign-in-keeps-accountdelete-tracks-hide-rolled-back,session-revoke-immediate,console-fixes-2026-10-18name-new-organizations,patch-check-publish-raceLeft out on purpose: internal, staff-only and feature-flagged changes (the hidden
/enterprisepage, the unused news dialog), a first-load blank-page fix, theorganization_idfield, and the Mission Control adoption version note.Docs pages the new entries link to, updated so they describe what the entries say:
org-switcher.tsx,create-organization-dialog.tsx,can-create-organization.ts). The two screenshots of the old UI are removed, with their image files.planOffersRoleinrole_grants.dart).--show-dex-diff(1.6.130).Would you like to continue? (y/N)line, a prompt 1.6.130 removed.npm run build(which validates every entry and docLink anchor), Prettier, cspell and Vale pass.Screenshots
New entries render from the existing template; the Organizations section loses two outdated screenshots.
Landing
As soon as approved.