fix: guard audio getVolume when volumeKeyframeBuilder is missing - #190
Merged
Merged
Conversation
dazzatronus
force-pushed
the
fix/audio-volume-keyframe-guard
branch
from
September 25, 2026 01:21
17892b4 to
ddced62
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
## [2.22.5](v2.22.4...v2.22.5) (2026-09-25) ### Bug Fixes * guard audio volume reads and rebuild keyframes on reload ([#190](#190)) ([acc4bfe](acc4bfe))
|
🎉 This PR is included in version 2.22.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volume-keyframe construction can fail after audio has loaded, leaving playback without a builder. Fall back to the configured volume when the builder is missing, and rebuild it before applying volume to replacement audio.
Verify:
npm run verify:cipasses on Node 22, including 2,084 tests.