[2/2] Preview animated video speed - #209
Draft
dazzatronus wants to merge 1 commit into
Draft
dazzatronus wants to merge 1 commit into
dazzatronus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, authors can't see a speed ramp before they render. The preview now plays a video's animated
speedthe way renders do. The source starts attrimand moves by the integrated speed curve (trapezoid rule, 0.01 s steps). The first and last speeds hold, and gaps blend linearly.playbackRaterange (holds, reverse, above 16×), the player pauses and seeks each tick instead. This also stops constant speeds below 0.0625 from throwing.speed, including an empty array, previews at 1×.Verify:
npm test. There are new cases inplayer-sync,media-player-fallbackandmedia-toolbar.Code:
createAnimatedSpeedgetSourceTimegetAssetSpeed