Support current Ossie profiles and preserve source semantics - #401
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nicosuave
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d919c97c31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elif file_path.name.lower().endswith((".ossie.json", ".ossie.yaml", ".ossie.yml")): | ||
| # An explicit format suffix also routes malformed documents to the | ||
| # validated parser, so they cannot silently become an empty graph. | ||
| if _is_generated_artifact(file_path, directory): | ||
| continue | ||
| adapter = ossie_adapter() |
There was a problem hiding this comment.
When auto-discovery sees a *.ossie.yaml or *.ossie.yml document using the supported dbt 0.1.0 compatibility version, this new early branch bypasses the YAML inspection below and constructs an ossie-core adapter. The parser consequently rejects the document because 0.1.0 requires dbt-1.12, whereas the previous YAML path selected that consumer automatically. Inspect valid suffixed YAML before choosing the default profile while retaining this branch for malformed documents. This affects default CLI discovery and validation workflows.
AGENTS.md reference: AGENTS.md:L5-L9
Useful? React with 👍 / 👎.
| elif ( | ||
| '"semantic_model"' in content | ||
| and '"datasets"' in content | ||
| and _is_under_osi_tree(file_path, directory) | ||
| '"datasets"' in content | ||
| and ('"semantic_model"' in content or ('"version"' in content and '"name"' in content)) | ||
| and (only_file is not None or _is_under_osi_tree(file_path, directory)) | ||
| and not _is_generated_artifact(file_path, directory) |
There was a problem hiding this comment.
For a current flat Ossie document named ordinarily, such as models/commerce.json, directory loading leaves only_file unset and the file is ignored unless it resides under OSI/; the same document is recognized when loaded directly or serialized as YAML. The OSI/ restriction was designed for released dbt artifacts, but this condition now also matches the current version/name/datasets profile, so CLI-first commands such as sidemantic validate models/ can silently omit valid current JSON sources. Apply the OSI-tree restriction only to the legacy envelope or otherwise recognize current flat JSON during project scans.
AGENTS.md reference: AGENTS.md:L5-L9
Useful? React with 👍 / 👎.
1 participant
Current flat Ossie documents could be missed by automatic CLI import, source serialization could reuse stale bytes after a JSON scalar-type change, and ontology references were not fully checked. This adds current logical/ontology profiles pinned to Apache Ossie
b6c702ewhile preserving released and older-draft documents.The source layer now preserves schema revisions and document shape, validates ontology identities/inheritance/roles/mappings, accepts YAML merge overrides without allowing authored duplicate keys, and bounds parser expansion. Synthesis preserves temporal roles and resolves native field placeholders; exact-source fallback produces a diagnostic. CLI conversion passes scope, dialect, import policy, and schema revision through to the Ossie APIs.
Local source/interchange/catalog/CLI validation: 672 passed. Ruff, formatting, and whitespace checks passed. Official schema/validator fixtures are pinned with provenance. Execution binding and aggregate-planner changes are in the following stack layers.