Repository navigation
rust(bug): include LICENSE at sdist root - #750
Merged
Merged
Conversation
wei-sift
marked this pull request as ready for review
August 21, 2026 21:42
solidiquis
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.5.0 release published all 49 wheels but PyPI rejected the sdist:
maturin declares
License-File: LICENSEin PKG-INFO because the crate has a LICENSE symlink (added in #695), but this crate's sdist is rooted at the workspace, so the file lands atrust/crates/sift_stream_bindings/LICENSE. PyPI resolves the declaration from the archive root, finds nothing, and fails the upload.Adding the LICENSE to
[tool.maturin] includeplaces a copy at the archive root where the metadata already points. Scoped toformat = "sdist"since wheels were never affected; they carry the license in.dist-info/licenses/.Reproduced the rejection locally with maturin 1.14.1, the version CI resolves, then confirmed the fixed sdist resolves
License-Filefrom the root.