Repository navigation
python(feat): add MCAP imports - #755
Merged
Merged
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-755/ Deployed from |
wei-sift
force-pushed
the
eng-12130-sift-client-mcap-imports
branch
from
August 27, 2026 18:16
cd5f9d4 to
3534540
Compare
wei-sift
marked this pull request as ready for review
August 27, 2026 20:19
marc-sift
reviewed
Sep 1, 2026
marc-sift
reviewed
Sep 1, 2026
marc-sift
requested changes
Sep 1, 2026
marc-sift
requested changes
Sep 17, 2026
marc-sift
previously approved these changes
Sep 17, 2026
marc-sift
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds MCAP (
.mcap) import support tosift_clientfor ROS 2 topics (ros2msg/cdr)detect_configreads the file's channels locally without decoding messages, giving one entry per flattened field named<topic>.<field_path>. Edit it to select, rename, or retype channels; leavedataempty to import everything.Variable-cardinality fields are typed
BYTES, withcomplex_types_import_modedeciding what each becomes, matching Parquet. Undecodable topics are skipped with a warning unlessparse_error_policyisIGNORE_ERROR, which fails the import.Adds the MCAP config types,
DataTypeKey.MCAP, an example, and a newmcapextra.Testing
Unit tests covering schema flattening, type mapping, topic rules, the three scan paths, and each complex types mode.
Manual imports with MCAP files