Repository navigation
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-769/ Deployed from |
wei-sift
marked this pull request as ready for review
August 31, 2026 23:45
alexluck-sift
approved these changes
Sep 1, 2026
wei-sift
deleted the
eng-14250-support-enum_types-on-all-sift_client-file-import-configs
branch
September 1, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Before:
ValueError: "CsvDataColumn" object has no field "enum_types"Enum channels were only supported on TDMS imports.
enum_typesnow lives onDataColumnBase, so all import config data columns (CSV, Parquet, HDF5, ULog) accept a{name: key}mapping.enum_typestoDataColumnBasewith a validator requiringChannelDataType.ENUM, remove the duplicate field onTdmsDataColumnChannelConfigProtovia a shared helper in every_to_proto, and read enums back in every_from_protoTesting
Unit tests and manual imports with enum configs, validated the output