Repository navigation
python(feat): annotations resource - #792
Merged
Merged
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-792/ Deployed from |
brandonshippy-sift
requested review from
alexluck-sift,
solidiquis and
wei-sift
September 17, 2026 20:25
brandonshippy-sift
marked this pull request as ready for review
September 17, 2026 20:25
wei-sift
requested changes
Sep 20, 2026
brandonshippy-sift
force-pushed
the
python/annotations-resource
branch
from
September 21, 2026 20:12
181876f to
b8fcb31
Compare
alexluck-sift
left a comment
alexluck-sift
left a comment
Collaborator
There was a problem hiding this comment.
Three comments. Also worth filing a ticket for the name: str | Iterable[str] collapse across the other twelve resources, so this PR isn't the only place with the new shape.
alexluck-sift
previously approved these changes
Sep 25, 2026
wei-sift
requested changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an annotations resource to
sift_client, covering data reviews, phases, and the review history.Annotation and all associated classes and enums are made.
Implements get, list_, find, create, update, assign_to_user, set_open, set_failed, set_accepted, archive/unarchive, add_comment
Validation