Repository navigation
Python(feat): warn on closed step and rollup status at closure - #821
Merged
Merged
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-821/ Deployed from |
alexluck-sift
marked this pull request as ready for review
October 8, 2026 18:12
ian-sift
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A measurement or outcome recorded on a step after its
withblock exited was silently dropped from the step tree: the step and every parent above it stayedPASSEDwhile only the report wentFAILED, producing a failed report in which every step passed. This fixes the roll-up and adds a warning so the mis-ordering is visible before it costs anyone a wrong report.Verification
measurecalls one dedent outside it) against a six-deep step tree: before, all six steps uploadedPASSEDwith the reportFAILED; after, all six areFAILEDwith one corrective write on the closed step and one update each for the rest.