Repository navigation
rust(docs): document bracket syntax for metadata filters - #829
Merged
Merged
Conversation
alexa-sift
previously approved these changes
Oct 13, 2026
The list tool descriptions told agents to filter metadata with
`metadata.{key}`. The service only accepts `metadata["<key>"]` and
rejects the dot form, so an agent that followed the description hit a
compile error and told the user runs can't be filtered on metadata.
- Swap `metadata.{key}` for `metadata["<key>"]` in every tool
description that documents metadata filtering, examples included.
- Add the same sentence to list_test_steps, list_test_measurements,
count_test_steps and count_test_measurements, which named `metadata`
as filterable without saying how to reference a key. Their proto
comments document the syntax.
- Update the authoring guide in sift_mcp/CLAUDE.md to show the bracket
form as the metadata-key syntax to preserve.
- Add a test that every tool whose `filter` mentions metadata shows the
bracket form and that no description shows a dot-form key.
ENG-15442
bill-sift
force-pushed
the
claude/keen-shannon-8th1di
branch
from
October 13, 2026 21:37
216c753 to
71009c3
Compare
alexa-sift
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list tool descriptions told agents to filter metadata with
metadata.{key}. The service only acceptsmetadata["<key>"]and rejects the dot form, so an agent that followed the description hit a compile error and told the user runs can't be filtered on metadata.metadata.{key}formetadata["<key>"]in every tool description that documents metadata filtering, examples included.metadataas filterable without saying how to reference a key. Their proto comments document the syntax.filtermentions metadata shows the bracket form and that no description shows a dot-form key.