Skip to content

rust(fix): exclude archived runs from get_data run_name lookup and add run_id - #834

Open
bill-sift wants to merge 3 commits into
mainfrom
claude/peaceful-keller-5lkvcm
Open

bill-sift wants to merge 3 commits into
mainfrom
claude/peaceful-keller-5lkvcm

Conversation

@bill-sift

Copy link
Copy Markdown
Contributor

Calls to get_data resolved run_name with limit 1 and no archive filter, so an archived run sharing a name with the active one could silently supply the data in its place.

  • Name lookup now filters is_archived == false and fetches two runs. More than one active match fails with INVALID_PARAMS listing the candidate run ids. A miss points at an archived run only when one holds the name.
  • New run_id param, mutually exclusive with run_name. It is the only way to fetch an archived run. Blank run selectors are rejected.
  • The result carries run_id, plus run_archived for an archived run, and the unresolved calculated channel report names the run by id.
  • explore_asset, analyze_run and derive_and_upload list active runs only and pass run_id to get_data, asking the user when a name matches more than one run.
  • Tests cover an archived duplicate, multiple active matches, run_id on an archived run, both not-found messages, and the new validation errors.

…d run_id

get_data resolved run_name with limit 1 and no archive filter, so an
archived run sharing a name with the active one could silently supply
the data in its place.

- Name lookup now filters is_archived == false and fetches two runs.
  More than one active match fails with INVALID_PARAMS listing the
  candidate run ids. A miss points at an archived run only when one
  holds the name.
- New run_id param, mutually exclusive with run_name. It is the only
  way to fetch an archived run. Blank run selectors are rejected.
- The result carries run_id, plus run_archived for an archived run, and
  the unresolved calculated channel report names the run by id.
- explore_asset, analyze_run and derive_and_upload list active runs only
  and pass run_id to get_data, asking the user when a name matches more
  than one run.
- Tests cover an archived duplicate, multiple active matches, run_id on
  an archived run, both not-found messages, and the new validation
  errors.

Fixes ENG-15763
alexa-sift
alexa-sift previously approved these changes Oct 14, 2026
solidiquis
solidiquis previously approved these changes Oct 14, 2026
@bill-sift
bill-sift dismissed stale reviews from solidiquis and alexa-sift via d951b20 October 15, 2026 00:03
@bill-sift
bill-sift enabled auto-merge (squash) October 15, 2026 00:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants