Repository navigation
Conversation
…te_rule Agents could not see or attach webhooks, so a request to alert someone when a rule fires lost its notification step. - New list_webhooks tool over ListWebhooks. The backend returns credentials in plaintext, so the tool keeps only the target URL's scheme and the last two labels of its host, header names, and no body template. - create_rule and update_rule take webhook_ids. On update_rule it replaces the rule's set, like asset_ids; omitted, the current webhooks are kept, even through a conditions_json rewrite, and next_step names any webhook detached. - Both tools confirm each webhook exists and is not archived before writing, since Sift accepts an archived webhook on a rule and never calls it. Webhook actions written into the conditions are refused so none skips that check. - create_rule documents the annotation action shape, and both tools check for exactly one condition. Sift answers a rule with none with an internal error.
bijan-sift
reviewed
Oct 15, 2026
…d-only webhook actions - An action typed WEBHOOK now counts as a webhook action with or without a configuration. It is refused in rule_json and conditions_json, and replacing the set with webhook_ids drops one that names no webhook. - update_rule checks only newly attached webhooks for archived status, so passing a rule's current set back is always safe. The rule is fetched and merged before the check, which adds no call. - The ListWebhooksRequest and ListWebhookLogsRequest order_by comments now say an empty order_by sorts newest first, matching the API.
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-837/ Deployed from |
bijan-sift
previously approved these changes
Oct 15, 2026
bijan-sift
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents could not see or attach webhooks, so a request to alert someone when a rule fires lost its notification step.