Skip to content

Fix Compare-InstallerSnapshots.ps1 StrictMode crash on empty UninstallEntries #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnml1135 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Compare-InstallerSnapshots.ps1 StrictMode crash on empty UninstallEntries #1008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a261384
Fix Compare-InstallerSnapshots.ps1 crash on empty entries
johnml1135 Jul 13, 2026
1051486
Trim Get-DisplayNameList comment to the 200-char budget
johnml1135 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions scripts/Agent/Compare-InstallerSnapshots.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,26 @@ function Diff-Sets {
return [pscustomobject]@{ Added = $added; Removed = $removed }
}

function Get-DisplayNameList {
# Tolerates $null, an unwrapped object, and the empty {} object Windows
# PowerShell emits for an empty list -- direct property access on those
# shapes throws under Set-StrictMode.
param([Parameter(Mandatory = $false)]$Entries)

$names = New-Object System.Collections.Generic.List[string]
if ($null -eq $Entries) { return ,$names }

foreach ($entry in @($Entries)) {
if ($null -eq $entry) { continue }
$prop = $entry.PSObject.Properties['DisplayName']
if ($null -eq $prop) { continue }
$value = [string]$prop.Value
if (-not [string]::IsNullOrWhiteSpace($value)) { $names.Add($value) }
}

return ,$names
}

function ConvertTo-PropertyMap {
param([Parameter(Mandatory = $false)]$Value)

Expand Down Expand Up @@ -86,14 +106,8 @@ $reportLines.Add("After: $AfterSnapshotPath")
$reportLines.Add("")

# Uninstall entries
$beforeProducts = @()
foreach ($p in ($before.UninstallEntries | ForEach-Object { $_ })) {
$beforeProducts += ([string]$p.DisplayName)
}
$afterProducts = @()
foreach ($p in ($after.UninstallEntries | ForEach-Object { $_ })) {
$afterProducts += ([string]$p.DisplayName)
}
$beforeProducts = Get-DisplayNameList -Entries $before.UninstallEntries
$afterProducts = Get-DisplayNameList -Entries $after.UninstallEntries

$diffProducts = Diff-Sets -Before (To-StringSet -Items $beforeProducts) -After (To-StringSet -Items $afterProducts)
$reportLines.Add("Uninstall entries")
Expand Down
Loading