Make word_align_corpus train lazily

[ddaspit]

• Properly cleans up the created model

---

This change is 

[Enkidu93]

This isn't used anywhere in silnlp, I don't believe. Is there anywhere else we should check / anyone else we should inform about this change in behavior?

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[ddaspit]

Transductive support was just added. I don't think anyone is using this function yet.

@ddaspit made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[Enkidu93]

I'm probably missing something: Now when you call word_align_corpus(), the model will potentially be trained every time you call get_rows() on the returned corpus rather than once, right? Won't that affect callers who are using word_align_corpus() already?

@Enkidu93 made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[ddaspit]

Yes, you are correct. It is a change in behavior, but it wasn't really "correct" before, because there was no way to clean up the model. I don't think any callers would be calling it multiple times anyway.

@ddaspit made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[Enkidu93]

OK, right. I confirmed it isn't used like this in silnlp - just wanted to make sure there wasn't anything else we should check. But yes, a caller really shouldn't be calling get_rows() repeatedly anyways.

@Enkidu93 made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

[codecov-commenter]

Codecov Report

❌ Patch coverage is 95.90164% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.01%. Comparing base (deb112b) to head (068b32e).

Files with missing lines	Patch %	Lines
machine/translation/corpus_ops.py	89.79%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   91.94%   92.01%   +0.07%     
==========================================
  Files         387      387              
  Lines       24381    24458      +77     
==========================================
+ Hits        22416    22505      +89     
+ Misses       1965     1953      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pmachapman]

I don't think any callers would be calling it multiple times anyway.

This should be true for the dotnet implementation, as it is IEnumerable, and dotnet gives you a code analysis warning if you iterate over an IEnumerable multiple times. (I'm not aware of a similar feature in Python.)

@pmachapman reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ddaspit).