Remove Chorus references from the docs and corpus provenance - #31
Open
imnasnainaec wants to merge 1 commit into
Open
Remove Chorus references from the docs and corpus provenance#31imnasnainaec wants to merge 1 commit into
imnasnainaec wants to merge 1 commit into
Conversation
The C# comparison page keeps its remaining subjects (SIL.Lift, SIL.DictionaryServices): the scope table drops its 3-way-merge row, the fidelity bullet describes per-entry byte chunking on its own terms, and SynchronicMerger is labeled by what it merges — LIFT update files — rather than by a library it does not live in. README's scope list and the changelog line about the comparison page lose the same reference, and the provenance note under "Not fetchable as files" keeps only the LiftTools finding and its pinned SHA. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
August 14, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
Every mention of Chorus is gone; each site was handled on its own terms rather than by deletion alone:
docs/en/csharp-differences.md— the intro now names only the libraries the page actually compares against (SIL.Lift,SIL.DictionaryServices). The scope table's3-way merge / syncrow is dropped, since Chorus was its only C# entry. The fidelity bullet states per-entry byte chunking directly instead of by comparison.SynchronicMergeris relabeled "LIFT update-file merging" — it lives inSIL.Lift/Merging/SynchronicMerger.csin libpalaso, not in Chorus, so the old parenthetical was also a misattribution.README.md— the scope bullet keeps "No merging" without the Chorus pointer.CHANGELOG.md— sanitized in place under the unreleased0.1.0section (no new entry).tests/corpus/PROVENANCE.md— the "Not fetchable as files" note keeps the LiftTools finding and its pinned SHA (f3e87cc…, verified to be the LiftTools one). No corpus file came from Chorus, so nothing carried loses its provenance.mkdocs build --strictpasses. No code or fixture bytes changed.🤖 Generated with Claude Code
Devin review: https://app.devin.ai/review/sillsdev/python-sil-lift/pull/31
This change is