Fix crash when initializing a WordAlignmentMatrix with one dimension - #16
Open
pmachapman wants to merge 1 commit into
Open
Fix crash when initializing a WordAlignmentMatrix with one dimension#16pmachapman wants to merge 1 commit into
pmachapman wants to merge 1 commit into
Conversation
pmachapman
force-pushed
the
fix_1d_matrix_crash
branch
from
August 13, 2026 01:36
20e5823 to
f482cb3
Compare
ddaspit
requested changes
Aug 13, 2026
| matrix = new bool*[I]; | ||
| bool* pool = new bool[(size_t)I * J]{false}; | ||
| const size_t size = std::max<size_t>(1, static_cast<size_t>(I) * J); | ||
| bool* pool = new bool[size]{false}; |
There was a problem hiding this comment.
Using an empty initializer is valid and gives the correct results, i.e.
if (I > 0)
{
matrix = new bool*[I];
bool* pool = new bool[(size_t)I * J]{};
for (unsigned int i = 0; i < I; ++i, pool += J)
matrix[i] = pool;
}|
|
||
| bool WordAlignmentMatrix::getValue(unsigned int i, unsigned int j) const | ||
| { | ||
| return matrix[i][j]; |
There was a problem hiding this comment.
We need proper bounds checking here:
if (i < I && j < J)
return matrix[i][j];
return false;| { | ||
| for (j = 0; j < aligVec.size(); ++j) | ||
| { | ||
| if (aligVec[j] > 0) |
There was a problem hiding this comment.
We need proper bounds checking here:
if (aligVec[j] > 0 && aligVec[j] <= I)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash exposed by the e2e test for sillsdev/machine.py#336, where the target pre-translations were blank.
Interestingly, the crash only occurs on Linux and macOS: https://github.com/sillsdev/thot/actions/runs/31657210462
The training data that exposes the crash is at crash_data.zip, and can be run with a unit test along the lines of: