Skip to content

SF-3838 Add date and text filter on onboarding requests tab - #4024

Open
RaymondLuong3 wants to merge 3 commits into
masterfrom
feature/sf-3838-onboarding-filter
Open

SF-3838 Add date and text filter on onboarding requests tab#4024
RaymondLuong3 wants to merge 3 commits into
masterfrom
feature/sf-3838-onboarding-filter

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

This PR adds the logic to allow filtering onboarding requests by date and strings in the request object. A new SearchRecordsComponent is now shared between the onboarding requests tab and the serval builds tab. Slight modifications were made to the template in the serval builds tab to align with the template in the Onboarding Requests tab.

Before
Onboarding No Search

After
Onboarding Search

Before
Serval Builds Before

After
Serval Builds After


This change is Reviewable

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.18%. Comparing base (d12160f) to head (19d6d07).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../serval-administration/search-records.component.ts 20.00% 4 Missing ⚠️
...boarding-requests/onboarding-requests.component.ts 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4024      +/-   ##
==========================================
+ Coverage   81.07%   81.18%   +0.11%     
==========================================
  Files         660      661       +1     
  Lines       43037    43091      +54     
  Branches     7057     7041      -16     
==========================================
+ Hits        34891    34984      +93     
+ Misses       6974     6951      -23     
+ Partials     1172     1156      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3
RaymondLuong3 force-pushed the feature/sf-3838-onboarding-filter branch from 4e09f28 to 8f6ed2e Compare August 6, 2026 17:20
@RaymondLuong3 RaymondLuong3 added will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels Aug 6, 2026
@RaymondLuong3
RaymondLuong3 marked this pull request as ready for review August 6, 2026 17:23
@Nateowami
Nateowami force-pushed the feature/sf-3838-onboarding-filter branch from 8f6ed2e to 19d6d07 Compare August 10, 2026 16:44
@Nateowami
Nateowami deployed to screenshot_diff August 10, 2026 16:52 — with GitHub Actions Active

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't think defaulting to a narrow date range on the onboarding request page is a good idea. The builds page and onboarding requests page are different in that:

  • Onboarding requests are something that need to be dealt with (it's like an inbox, and limited to one per project)
  • Builds are something you can review (it's like a log, and has no limit and can grow massive)

We probably do need to add some kind of filtering to avoid showing too many elements at once, but right now the default filtering already mostly addresses it.

It also creates some very non-intuitive views. If you click on "All" you might expect it might be filtered to recent issues and you could select to show more. But if you click on "mine" and it says there are none, you're probably not going to realize you have to select a wider time range to see all, and there's no option to show all.

@Nateowami made 1 comment.
Reviewable status: 0 of 10 files reviewed, all discussions resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants