Skip to content

SF-1818 Fix note dialog being incorrectly closed - #4045

Draft
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-1818-fix-note-dialog-incorrectly-closed
Draft

SF-1818 Fix note dialog being incorrectly closed#4045
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-1818-fix-note-dialog-incorrectly-closed

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

The real bug was in the dialog service which in openMatDialog was not honoring disableClosed when passed in the options, because it would override the disableClose from the option with the positional argument.

I've eliminated the positional argument, since I think passing a boolean is very unclear. Meanwhile passing { disableClose: true } is very clear what it means.


This change is Reviewable

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (99fe5e2) to head (6505b29).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...aft-signup-form/draft-onboarding-form.component.ts 0.00% 1 Missing ⚠️
...ture/ClientApp/src/xforge-common/dialog.service.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
+ Coverage   81.08%   81.09%   +0.01%     
==========================================
  Files         661      661              
  Lines       43058    43054       -4     
  Branches     7036     7059      +23     
==========================================
+ Hits        34912    34915       +3     
+ Misses       6989     6981       -8     
- Partials     1157     1158       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant