Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195.
Map the common superscript and subscript digits and the letters used in ordinal suffixes to their plain ASCII equivalents. This keeps the numeric meaning of units and chemical formulas in slugs:
15 m³now becomes15-m3, andH₂ObecomesH2O. The generatedslugify.jsmap is rebuilt fromconfig/charmap.json.Added regression cases for both examples, the digit sets, and ordinal suffixes.
Local verification:
node node_modules/mocha/bin/mocha --recursivepassed all 46 tests; direct Node execution confirmed the example outputs;git diff --checkpassed. The package test script callsnpx, which is unavailable in this environment, so Mocha was run directly.