Fix your hosting auto events#87
Closed
adriaandotcom wants to merge 7 commits into
Closed
Conversation
Links with target="_self" stopped navigating when auto events was active. collectLink adds "return false" to the onclick for links with no target or target="_self", which cancels the browser navigation, but the saAutomatedLink callback only navigated when the link had no target at all. So target="_self" links sent the event and then never navigated. The callback now uses the same target check as collectLink, so target="_self" navigates in the same tab after the event, while target="_blank" and other targets keep their native behaviour. Fix for YourHosting, button "Ik wil zelf alles regelen" on https://www.yourhosting.nl/webhosting-2/
Collaborator
Author
|
@claude review this PR. |
Collaborator
Author
|
Closing in favour of #88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.