fix(db): correct misleading error message when DATABASE_REPLICA_URL is malformed

[salarkhannn]

The error message claimed reads fall back to the primary when DATABASE_REPLICA_URL is unset, but this only applies when the variable is absent entirely. When the variable is set to an invalid value, the code throws a fatal error — there is no graceful fallback. The misleading parenthetical contradicted the actual behavior and could misdirect operators debugging a configuration issue during an incident.

[vercel]

@salarkhannn is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

[cursor]

PR Summary

Low Risk
String-only change to a startup validation error message; no runtime logic or connection behavior changes.

Overview
Updates the thrown error when DATABASE_REPLICA_URL is present but not a valid postgres:// / postgresql:// DSN.

The message no longer implies that reads fall back to the primary when the variable is unset—that fallback only applies when the env var is absent. When it is set to a bad value, startup still fails; the text now tells operators to fix the URL or unset the variable instead of pointing at unset behavior.

^{Reviewed by Cursor Bugbot for commit 4027930. Bugbot is set up for automated code reviews on this repo. Configure here.}

[greptile-apps]

Greptile Summary

This PR corrects a misleading error message in packages/db/db.ts. The old message implied that reads fall back to the primary when DATABASE_REPLICA_URL is unset, but that fallback only applies when the variable is absent entirely — not when it holds an invalid value. When the URL is set but malformed, the code throws a fatal error with no fallback, so the parenthetical actively misdirected operators during incident debugging.

• The new message (fix the URL or unset the variable) accurately reflects the two available remediation paths without implying a graceful fallback that doesn't exist in this code path.
• The JSDoc comment at line 28–29, which correctly documents the designed absent-URL fallback behavior, is unchanged and remains accurate.

Confidence Score: 5/5

The change touches only a string literal inside an error-throw branch that is already exercised solely when startup validation fails. No runtime logic, schema, or data path is altered.

The edit replaces one error message string with a more accurate one. The validation condition, the throw, and every code path around it are left untouched. The corrected wording removes a clause that contradicted actual behavior, making the message a faithful description of what operators must do to recover.

No files require special attention.

Important Files Changed

Filename	Overview
packages/db/db.ts	Single-line error message correction: removes the misleading "(reads fall back to the primary when unset)" parenthetical from the malformed-URL error path, where no fallback actually occurs.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Module loads] --> B{DATABASE_REPLICA_URL set?}
    B -- No / undefined --> C[dbReplica = db primary\nsilent fallback]
    B -- Yes --> D{Matches postgres:// DSN?}
    D -- No --> E[throw Error\n'fix the URL or unset the variable'\nno fallback]
    D -- Yes --> F[dbReplica = drizzle replica client]

Loading

_{Reviews (1): Last reviewed commit: "fix(db): correct misleading error messag..." | Re-trigger Greptile}