improvement(react-query): codebase-wide audit — server-state hooks, webhook coherence, resume migration

.claude/rules/sim-queries.md

@@ -137,3 +137,7 @@ const handler = useCallback(() => {
 - **Query hooks**: `useEntity`, `useEntityList`
 - **Mutation hooks**: `useCreateEntity`, `useUpdateEntity`, `useDeleteEntity`
 - **Fetch functions**: `fetchEntity`, `fetchEntities` (private)
+
+## Enforcement
+
+`scripts/check-react-query-patterns.ts` (`bun run check:react-query`, run in CI) statically enforces these conventions: every `useQuery`/`useInfiniteQuery`/`useSuspenseQuery` declares an explicit `staleTime`, inline `queryFn`s destructure `signal`, `queryKey`s reference a colocated factory rather than an inline literal, and every `*Keys` factory in `hooks/queries/**` exposes an `all` root key. `hooks/queries/**` is a zero-tolerance zone; the rest of `apps/sim/**` is ratcheted against `scripts/check-react-query-patterns.baseline.json`. For a genuine exception, put `// rq-lint-allow: <reason>` on the line directly above the flagged construct.

.github/workflows/test-build.yml

@@ -112,6 +112,9 @@ jobs:
       - name: Zustand v5 selector audit
         run: bun run check:zustand-v5
 
+      - name: React Query pattern audit
+        run: bun run check:react-query
+
       - name: Verify realtime prune graph
         run: bun run check:realtime-prune
 

apps/sim/app/(landing)/components/demo-request/demo-request-modal.tsx

@@ -1,6 +1,7 @@
 'use client'
 
 import { useState } from 'react'
+import { getErrorMessage } from '@sim/utils/errors'
 import { useMutation } from '@tanstack/react-query'
 import {
   ChipCombobox,
@@ -128,9 +129,7 @@ export function DemoRequestModal({ children, theme = 'dark' }: DemoRequestModalP
   }
 
   const submitError = demoMutation.isError
-    ? demoMutation.error instanceof Error
-      ? demoMutation.error.message
-      : 'Failed to submit demo request. Please try again.'
+    ? getErrorMessage(demoMutation.error, 'Failed to submit demo request. Please try again.')
     : null
 
   return (

apps/sim/app/api/resume/[workflowId]/[executionId]/[contextId]/route.ts

@@ -2,7 +2,10 @@ import { createLogger } from '@sim/logger'
 import { toError } from '@sim/utils/errors'
 import { generateId } from '@sim/utils/id'
 import { type NextRequest, NextResponse } from 'next/server'
-import { resumeWorkflowExecutionContextContract } from '@/lib/api/contracts/workflows'
+import {
+  getPauseContextDetailContract,
+  resumeWorkflowExecutionContextContract,
+} from '@/lib/api/contracts/workflows'
 import { parseRequest } from '@/lib/api/server'
 import { AuthType } from '@/lib/auth/hybrid'
 import { getJobQueue } from '@/lib/core/async-jobs'
@@ -310,7 +313,7 @@ export const GET = withRouteHandler(
       params: Promise<{ workflowId: string; executionId: string; contextId: string }>
     }
   ) => {
-    const parsed = await parseRequest(resumeWorkflowExecutionContextContract, request, context)
+    const parsed = await parseRequest(getPauseContextDetailContract, request, context)
     if (!parsed.success) return parsed.response
     const { workflowId, executionId, contextId } = parsed.data.params