Skip to content

fix(credentials): render the credential selector with the editor combobox - #7913

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/coda-credential-selector
Sep 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/coda-credential-selector

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Credential selector renders Combobox again instead of ChipCombobox, so credential fields match the combobox and selector pickers around them in the block editor
  • ChipCombobox only changes the trigger chrome (30px rounded chip, chip surface), so behavior (search, groups, connect actions, overlay icon) is unchanged

Type of Change

  • Bug fix

Testing

  • Sub-block editor tests passing (160)
  • bun run lint, check:audits, block registry check, and docs-manifest:check passing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 3:13am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The behavioral change appears low risk, but the explicit chip-family component requirement must be satisfied before merging.

Findings

  1. P2 Legacy Combobox Violates Standard

Summary

This PR changes the workflow editor’s credential selector from ChipCombobox to the underlying Combobox.

  • Credential selection, search, grouping, loading, overlay, and callback behavior remain unchanged because both controls use the same prop contract and implementation.
  • The change removes the chip-specific trigger chrome but conflicts with the repository’s explicit requirement to prefer chip-family controls.

Reviews (1) · Last reviewed commit: "fix(credentials): render the credential ..."

@waleedlatif1
waleedlatif1 merged commit 59a364a into staging Sep 17, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/coda-credential-selector branch September 17, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant